Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce workaround for module names that end with "-test" prefix #1646

Open
wants to merge 1 commit into
base: jb-main
Choose a base branch
from
Open

Introduce workaround for module names that end with "-test" prefix #1646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion buildSrc/private/src/main/kotlin/androidx/build/AndroidXComposeMultiplatformExtensionImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,14 @@ open class AndroidXComposeMultiplatformExtensionImpl @Inject constructor(
}

override fun js(): Unit = multiplatformExtension.run {
js(KotlinJsCompilerType.IR) {
js(KotlinJsCompilerType.IR) {
// We have to rename such modules (as npm packages exclusively - this does not affect anything package conventions in the prod artifact
// This is a workaround for https://youtrack.jetbrains.com/issue/KT-72362/js-running-tests-leads-to-compilation-error-if-one-modules-name-is-a-special-prefix-to-another-one
// TODO: get rid of this workaround as soon as we'll have a fix in tooling
if (project.name.endsWith("-test")) {
moduleName = project.name + "-npm"
}

browser {
testTask {
it.useKarma {
Expand Down
Loading