Fix kotlin.IndexOutOfBoundsException.

[bennyhuo]

Close a ComposeSceneLayer will also remove it from the container, thus making the layers modified while being iterated. Iterating the layers reversely may be the simplest fix since the removal always happens to the last element.

[MatkovIvan]

Thanks for the contribution! I would love to see some tests and/or a comment about it, but LGTM as a hot fix.

For the proper fix, I guess we need to split dispose and close in the layer implementation (no need for it in the interface)

[elijah-semyonov]

Oh, yeah, I've noticed this exact piece of code while investigating a new layers approach. It will be remade soon, but we can merge it until then if it fixes the issue. I'm not actually sure why it doesn't throw the concurrent modification exception in this case.

[bennyhuo]

Oh, yeah, I've noticed this exact piece of code while investigating a new layers approach. It will be remade soon, but we can merge it until then if it fixes the issue. I'm not actually sure why it doesn't throw the concurrent modification exception in this case.

If you use rememberComposeSceneLayer to maintain a ComposeSceneLayer, it will be closed in a DisposableEffect block. But the code may crash otherwise.

internal fun rememberComposeSceneLayer(
    focusable: Boolean = false
): ComposeSceneLayer {
    ....
    val layer = remember {
        ...
    }
    layer.focusable = focusable
    DisposableEffect(Unit) {
        onDispose {
            layer.close()
        }
    }
    ...
    return layer
}