Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve id creation for trace diagram #40

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Improve id creation for trace diagram #40

merged 1 commit into from
Jan 18, 2024

Conversation

rafaelldi
Copy link
Collaborator

Because some clients may use deprecated attributes, I've rewritten the logic to create diagram node ids.

See the documentation https://opentelemetry.io/docs/specs/semconv/http/http-spans/ and https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/

Fixes #39

@rafaelldi rafaelldi self-assigned this Jan 18, 2024
Copy link

Qodana Community for JVM

8 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 3
Unused import directive 🔶 Warning 2
Redundant semicolon 🔶 Warning 1
Boolean literal argument without parameter name ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@rafaelldi rafaelldi merged commit 1ec7632 into main Jan 18, 2024
6 checks passed
@rafaelldi rafaelldi deleted the improve-traces branch January 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace diagram can be broken because of the deprecated span attributes
1 participant