Added sealed type support #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2022 18:32
- Added sealed support to BnfDiagram - Added inspections for sealed rules - Updated default Java version to 17
|
The concept of having rules with interface but without implementations are new to the PSI structure. There are many concepts that rely on this, such as So far the behavior presented here pretty much ignores all of them but Also, if someone accidentally extends a sealed type, the sealed type semantics are dropped. (there's an inspection for this, see Any thoughts on this, and are there any assumptions that are broken by this approach? |
added 3 commits
November 26, 2022 18:48
…getSuperInterfaceNames being broken
- Removed massive test files in favor of assertGeneratesSameCode assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#305