feat: EXPOSED-494 Inline DSL statement and query functions #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bog-walk
commented
Oct 11, 2024
Comment on lines
188
to
208
| fun <T : Table> T.deleteReturning( | ||
| returning: List<Expression<*>> = columns | ||
| ): ReturningStatement { | ||
| val delete = DeleteStatement(this, where?.let { SqlExpressionBuilder.it() }, false, null) | ||
| val delete = DeleteStatement(this, null, false, null) | ||
| return ReturningStatement(this, returning, delete) | ||
| } |
There was a problem hiding this comment.
I created some new overloads to avoid issues with nullable parameters + inline.
I would have liked to be able to call one from the other instead of duplicating logic, but I couldn't get that to work given the nature of SqlExpressionBuilder.() -> Op<Boolean>.
@e5l Please let me know if any of these don't make sense to split just for inline.
e5l
approved these changes
Oct 14, 2024
Comment on lines
188
to
208
| fun <T : Table> T.deleteReturning( | ||
| returning: List<Expression<*>> = columns | ||
| ): ReturningStatement { | ||
| val delete = DeleteStatement(this, where?.let { SqlExpressionBuilder.it() }, false, null) | ||
| val delete = DeleteStatement(this, null, false, null) | ||
| return ReturningStatement(this, returning, delete) | ||
| } |
Make as many eligible statement and query functions inline where possible. Functions with nullable functional type paramaters have been marked noinline, but this may change upon review.
- Add crossinline keyword to body parameters to prevent non-local returns - Duplicate functions with null where parameters to allow inline
- Introduce back original extension functions (with nullable parameters) as deprecated versions. - Update .api dump
bog-walk
force-pushed
the
bog-walk/inline-dsl-functions
branch
from
d5f1d2c to
6e78edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
Add
inlinemodifier to query functions that are passed lambda parameters.Detailed description:
inlinemodifier to query functions, where possible, withcrossinlinemodifier on body/block parameters to prevent non-local returns.noinlineon nullablewherelambda parameters, some functions have been duplicated as overloads instead.Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-494