Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Modify Oracle numeric data types #2268

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

joc-a
Copy link
Collaborator

@joc-a joc-a commented Oct 8, 2024

Description

Detailed description:

  • What:
    The SQL type of some Oracle and H2 Oracle numeric types were changed.
  • Why:
  1. To not take up more space than needed
  2. It is a preparation step for making detecting column type change for migration easier

Next step: Do the same thing for the Integer and Long type, but I decided to proceed without it as there are some issues I must solve with SQLite first.

⚠️ Please review commit by commit because I will not squash the commits when merging.


Type of Change

Please mark the relevant options with an "X":

  • Bug fix
  • New feature
  • Documentation update
  • Improvement

Updates/remove existing public API methods:

  • Is breaking change

Affected databases:

  • MariaDB
  • Mysql5
  • Mysql8
  • Oracle
  • Postgres
  • SqlServer
  • H2
  • SQLite

Checklist

  • Unit tests are in place
  • The build is green (including the Detekt check)
  • All public methods affected by my PR has up to date API docs
  • Documentation for my change is up to date

Related Issues

joc-a added 2 commits October 8, 2024 15:56
…R(3) to not take up more space than needed as UByte has a maximum of three digits
…ER(5) to not take up more space than needed as UShort has a maximum of five digits
@joc-a joc-a changed the title chore: Modify Oracle numeric data types chore!: Modify Oracle numeric data types Oct 8, 2024
…ype from NUMBER(13) to NUMBER(10) to not take up more space than needed as UInt has a maximum of ten digits
@joc-a joc-a force-pushed the joc/modify-oracle-numeric-data-types branch from 7e9916a to 0448217 Compare October 8, 2024 15:08
@joc-a joc-a marked this pull request as ready for review October 8, 2024 15:55
@joc-a joc-a requested review from obabichevjb and bog-walk October 8, 2024 15:55
@joc-a joc-a merged commit 9697dbc into main Oct 10, 2024
5 checks passed
@joc-a joc-a deleted the joc/modify-oracle-numeric-data-types branch October 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants