Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Change MySQL connector Driver class name and version #1875

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

bog-walk
Copy link
Member

@bog-walk bog-walk commented Oct 4, 2023

Every MySQL test shows the following log when run:

mysql_driver_log

Change notes confirm that the driver class name used in exposed-tests is deprecated.

The MySQL version used for testing is also bumped to 8.0.33.

Note: Could bump to latest 8.1.0, but it is fairly recent (2023-07-18, GA) and would require a dependency change (new groupId and artifactId) and refactoring of 1 unit test.

Note: I don't foresee complications, but please consider running MySQL tests locally to check that the new driver doesn't cause any issues.

The current driver used in exposed-tests would log a warning that the class name
has been deprecated, for every test.

The dependency version used is also bumped from 8.0.30 to 8.0.33.
@bog-walk bog-walk requested review from e5l and joc-a October 4, 2023 15:48
Copy link
Collaborator

@joc-a joc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully ran tests locally 🎉

@bog-walk bog-walk merged commit 3985ef7 into main Oct 11, 2023
3 checks passed
@bog-walk bog-walk deleted the bog-walk/bump-mysql-driver branch October 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants