fix: EXPOSED-178 DELETE_RULE read incorrectly for Oracle #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oracle returns CASCADE=0, SET_NULL=2, and NO_ACTION=1 `decode (f.delete_rule, 'CASCADE', 0, 'SET NULL', 2, 1) as delete_rule` So when it returns 1, which in the current code corresponds to DatabaseMetaData.importedKeyRestrict, it will now be mapped to NO_ACTION because Oracle does not have the RESTRICT reference option. NO_ACTION behaves likes RESTRICT for it.
joc-a
force-pushed
the
joc/oracle-delete-rule-fix
branch
from
6067a1d to
aafda2b
Compare
bog-walk
approved these changes
Sep 25, 2023
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
) Oracle returns CASCADE=0, SET_NULL=2, and NO_ACTION=1 `decode (f.delete_rule, 'CASCADE', 0, 'SET NULL', 2, 1) as delete_rule` So when it returns 1, which in the current code corresponds to DatabaseMetaData.importedKeyRestrict, it is mapped to RESTRICT, which is not supported in Oracle. Instead of that, it will now be mapped to NO_ACTION. The resolveRefOptionFromJdbc function was moved from Constraints.kt to DatabaseDialect.kt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle returns CASCADE=0, SET_NULL=2, and NO_ACTION=1
decode (f.delete_rule, 'CASCADE', 0, 'SET NULL', 2, 1) as delete_ruleSo when it returns 1, which in the current code corresponds to
DatabaseMetaData.importedKeyRestrict, it is mapped toRESTRICT, which is not supported in Oracle. Instead of that, it will now be mapped toNO_ACTION.The
resolveRefOptionFromJdbcfunction was moved fromConstraints.kttoDatabaseDialect.kt.