chore: EXPOSED-186 Replace JDK 1.7 support in exposed-jodatime classes #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both column type classes in exposed-jodatime contain companion objects that check for java.time classes that were only introduced since JDK 1.8. This was implemented because the module was expected to run on Java version 1.7 and to be compatible with legacy android versions. Since the jvmToolchain has been to set to 8, this logic is no longer needed.
bog-walk
changed the title
e5l
approved these changes
Sep 24, 2023
joc-a
approved these changes
Sep 25, 2023
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
JetBrains#1866) * chore: Replace JDK 1.7 support in exposed-jodatime classes Both column type classes in exposed-jodatime contain companion objects that check for java.time classes that were only introduced since JDK 1.8. This was implemented because the module was expected to run on Java version 1.7 and to be compatible with legacy android versions. Since the jvmToolchain has been to set to 8, this logic is no longer needed. * chore: Replace JDK 1.7 support in exposed-jodatime classes Add apiDump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both column type classes in
exposed-jodatimecontain companion objects that check forjava.timeclasses that were only introduced in JDK 1.8 (LocalDateTime,OffsetDateTime).This was implemented because the module was expected to run on Java version 1.7 and to be compatible with legacy android versions.
Since the
jvmToolchainhas now been to set to 8, support for 1.7 is no longer needed and the classes can be referenced directly.