Skip to content

Conversation

@martijndormans
Copy link

@quinnturner I fixed the comment you made on PR: #96
I kinda need it very fast for my project at work hence I fixed the comment for you.

@quinnturner
Copy link

I apologize, but I am not a maintainer. I commented on that ticket to expedite the turnaround for this change, aiming to avoid an extra back-and-forth between the author and maintainer.

I still don't think you need to wait for this change to get merged to use Storybook 10 in your project because this package already exports ESM.

@martijndormans
Copy link
Author

Ah okay I did not know that

Yis it would work, but than I would need to install it with npm i --legacy-peer-deps
I am not a fan of that, Storybook should not interfere with my normal development work. And this is interfering.

@martijndormans
Copy link
Author

Maybe @JesusTheHun can take a look at this PR then?

@CodeWitchBella
Copy link

CodeWitchBella commented Nov 7, 2025

uhm, wtf guys 😄

Just wait, this is (I presume) volunteer-run opensource project.

Couple of points in the meantime: just don't update right away? There are no big features in storybook 10 and if you're not running into any bugs, there's no harm.

There are also tools for resolving this kind of issue:

  • --legacy-peer-deps
  • overrides
  • install from git repo branch

Also, taking someone elses work and passing it off as your own is very much against opensource etiquette (you squashed all the commits). Don't do that. For this PR it's mostly whatever, but still.

The reason why I didn't resolve the comment because I'd like to first see a comment from maintainer before I go and resolve comments from drive-by-reviewers. Edit: my brain was fried, the comment was good, resolved in my PR.

Finally, if this is interfering with your normal development work, you should probably adjust your process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants