Remove all Lightning/zap code, rename to Pulse ZERO v1#14
Open
joeynyc wants to merge 13 commits intoJesseRod329:mainfrom
Open
Remove all Lightning/zap code, rename to Pulse ZERO v1#14joeynyc wants to merge 13 commits intoJesseRod329:mainfrom
joeynyc wants to merge 13 commits intoJesseRod329:mainfrom
Conversation
Payments involve legal considerations, so this removes all NIP-57 zap support: BOLT11 invoice parsing, LNURL service, wallet integration, zap UI, and ZapSecurityGuard. Nostr identity and transport remain since they power messaging. Also fixes pre-existing build issues (missing pbxproj entries, MCSessionDelegate conformance, DebugLogger category, animation syntax). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removed redundant sections (Security Components table, Documentation table, Cryptographic Primitives, Test Suite table). Added shields.io badges, How It Works explainer, Requirements, Contributing section, and updated footer credit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What was removed
15 source/test files deleted (~3,100 lines):
Zap.swift,ZapManager.swift,LNURLService.swift,Bolt11Parser.swift,Bolt11Validator.swift,ZapSecurityGuard.swift,AmountGuard.swift,WalletURISanitizer.swiftZapButton.swift,ZapAmountSheet.swift,ZapDisplayView.swiftBolt11ParserTests.swift,Bolt11ValidatorTests.swift,ZapSecurityGuardTests.swift,WalletURISanitizerTests.swiftBITCOIN_PLAN.mdZap references cleaned from 8 source files:
NostrTransport.swift— removed zap event kinds, zap callbacks, zap publish/subscribe methods,lightningAddressfrom metadataNostrEventValidator.swift— removedvalidateZapRequest(),validateZapReceipt()PulsePeer.swift— removedlightningAddress,canReceiveZapsChatView.swift— removed zap UI (ZapDisplayView, ZapAmountSheet, ZapDetailsSheet)ProfileView.swift— removed lightning address field and metadata publishingSettingsView.swift— removed wallet picker, zap amount picker, lightning sectionMeshManager.swift— removedlightningAddressfrom demo peersSecureNetworkSession.swift— removedcreateLNURLSession()What stays untouched
Test plan
xcodebuild buildsucceeds (0 errors)xcodebuild test— all tests pass except 2 pre-existing failures unrelated to this changegrep -ri "zap\|bolt11\|lnurl"only matches ErrorManager scrub regex and its tests🤖 Generated with Claude Code