Skip to content

Remove all Lightning/zap code, rename to Pulse ZERO v1#14

Open
joeynyc wants to merge 13 commits intoJesseRod329:mainfrom
joeynyc:main
Open

Remove all Lightning/zap code, rename to Pulse ZERO v1#14
joeynyc wants to merge 13 commits intoJesseRod329:mainfrom
joeynyc:main

Conversation

@joeynyc
Copy link
Contributor

@joeynyc joeynyc commented Feb 6, 2026

Summary

  • Remove all NIP-57 Lightning zap support (BOLT11 parsing, LNURL service, wallet integration, zap UI, ZapSecurityGuard) since payments involve legal considerations
  • Keep Nostr identity and transport intact — they power messaging, not just payments
  • Rename project to Pulse ZERO v1 — a pure decentralized messaging app
  • Fix pre-existing build issues: missing pbxproj entries for 7 source files, MCSessionDelegate conformance, DebugLogger category, animation syntax

What was removed

15 source/test files deleted (~3,100 lines):

  • Zap.swift, ZapManager.swift, LNURLService.swift, Bolt11Parser.swift, Bolt11Validator.swift, ZapSecurityGuard.swift, AmountGuard.swift, WalletURISanitizer.swift
  • ZapButton.swift, ZapAmountSheet.swift, ZapDisplayView.swift
  • Bolt11ParserTests.swift, Bolt11ValidatorTests.swift, ZapSecurityGuardTests.swift, WalletURISanitizerTests.swift
  • BITCOIN_PLAN.md

Zap references cleaned from 8 source files:

  • NostrTransport.swift — removed zap event kinds, zap callbacks, zap publish/subscribe methods, lightningAddress from metadata
  • NostrEventValidator.swift — removed validateZapRequest(), validateZapReceipt()
  • PulsePeer.swift — removed lightningAddress, canReceiveZaps
  • ChatView.swift — removed zap UI (ZapDisplayView, ZapAmountSheet, ZapDetailsSheet)
  • ProfileView.swift — removed lightning address field and metadata publishing
  • SettingsView.swift — removed wallet picker, zap amount picker, lightning section
  • MeshManager.swift — removed lightningAddress from demo peers
  • SecureNetworkSession.swift — removed createLNURLSession()

What stays untouched

  • Nostr identity (secp256k1 signing) and relay transport — powers messaging
  • Mesh networking (BLE + MultipeerConnectivity)
  • Location channels, encryption, all security hardening
  • ErrorManager scrub regex for lightning strings (defense-in-depth)

Test plan

  • xcodebuild build succeeds (0 errors)
  • xcodebuild test — all tests pass except 2 pre-existing failures unrelated to this change
  • grep -ri "zap\|bolt11\|lnurl" only matches ErrorManager scrub regex and its tests

🤖 Generated with Claude Code

joeynyc and others added 13 commits February 6, 2026 16:05
Payments involve legal considerations, so this removes all NIP-57 zap
support: BOLT11 invoice parsing, LNURL service, wallet integration, zap
UI, and ZapSecurityGuard. Nostr identity and transport remain since they
power messaging. Also fixes pre-existing build issues (missing pbxproj
entries, MCSessionDelegate conformance, DebugLogger category, animation
syntax).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removed redundant sections (Security Components table, Documentation
table, Cryptographic Primitives, Test Suite table). Added shields.io
badges, How It Works explainer, Requirements, Contributing section,
and updated footer credit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant