Repository navigation
fix(memory): emit posix paths in memory index on Windows - #17
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
Author
|
The pull-request workflow runs are currently waiting for maintainer approval. Please approve them when convenient so CI can run against this revision. |
Path stringification uses backslashes on Windows, so nested index entries failed equality checks in test_memory_retrieval. Use as_posix() and cover it on Linux by stubbing relative_to to return PureWindowsPath — Ubuntu CI never exercised the old bug.
ryanduguid
force-pushed
the
fix/windows-path-separators
branch
from
September 6, 2026 10:26
71e6a30 to
7adb404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str(Path), which emits backslashes on Windows and breakstest_memory_retrievalnested-path assertions (corrections/collections.md)..as_posix()so agents and YAML round-trips see the same separators on every OS.Path.relative_toto returnPureWindowsPath, because Ubuntu CI never caught this (noted on Australian localisation pack: AU calendar, payroll, GST/BAS #14).This is the small Windows fix from openfpa#14. It does not include the Australian pack.
A previous PR (#15) had the one-line change without a CI-reproducible test and was closed unmerged.
Test plan
pytest tests/test_memory_retrieval.py(5 passing, including the new backslash stub)pytest -qgreen locally