Closed
Conversation
Align more with LIAAD/yake so that the tests we have are all in agreement. Add new test that does not quite match.
(Also remove leftover print statements)
Previous code was removing multiple characters.
Matches LIAAD/yake logic. I would prefer not to run to_single twice, but I won't fix that here.
|
I absolutely love it! ❤️ Totally understand your pain with PRs, if I were you, I would experience frustration 🤪 Did @quesurifn include you into the repo? If not, I would collect all the commits from that stuck PR, from your serde branch, from this PR, and made a final PR to the |
Owner
Author
|
That relief! Rebase incoming |
|
Jean,
I've added you as a collaborator. Thanks for @ing me Igor.
…On Tue, Jan 21, 2025 at 10:08 AM Jean Bvt ***@***.***> wrote:
That relief!
Rebase incoming
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFA5NV37NHAH5SONODZAQM32LZ5IXAVCNFSM6AAAAABVSXTAQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGI4TIOJQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Jeanbouvatt
force-pushed
the
cli-enhancements
branch
from
f68040d to
f728669
Compare
Co-authored-by: Igor Strebz <xamgore@users.noreply.github.com>
Jeanbouvatt
force-pushed
the
cli-enhancements
branch
from
f728669 to
ac67438
Compare
Owner
Author
|
closed in favor of quesurifn#48 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series of small improvement to the CLI
Creating PR on PR on PR can be cumbersome so I'll wait for parent PR to be merged into main code before rebasing and dedrafting, feel free to comment though.
If you feel the different changes need to be split into different PR, just ask :)