Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --no-quit flag #5

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Added --no-quit flag #5

merged 1 commit into from
Jan 12, 2024

Conversation

Bilge
Copy link
Contributor

@Bilge Bilge commented Jan 19, 2022

Consider adding --no-quit because the application lifecycle should be managed by Docker rather than from the web UI. Note that the most popular MailCatcher image with over 10 million pulls also does this.

@Jean-Beru Jean-Beru merged commit 537a5a0 into Jean-Beru:master Jan 12, 2024
@Jean-Beru
Copy link
Owner

Thanks you @Bilge ! Sorry for the delay, I discovered that this image still exists 😅

@Bilge Bilge deleted the patch-2 branch January 13, 2024 01:22
@Bilge
Copy link
Contributor Author

Bilge commented Jan 25, 2024

This change is meaningless without a release. That's what #4 is for.

@Jean-Beru
Copy link
Owner

Sure, I saw this PR. But I have to fix the build step (in a Github Action job I think) since hub.docker.com requires now a paid plan to do that.

I hope I can do that next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants