Add hostname to output#9
Merged
Merged
Conversation
- Add hostname to UI title bar: "ibtop - InfiniBand Monitor @ {hostname}"
- Add hostname field to JSON output wrapper
- Add hostname crate dependency
Closes #8
There was a problem hiding this comment.
Pull request overview
This PR adds hostname information to both the UI title bar and JSON output, making it easier to identify which host is being monitored, especially useful in multi-host environments.
- Adds
hostnamecrate (v0.4) as a dependency - Wraps JSON output in a new
IbtopOutputstruct containing hostname and adapters - Displays hostname in the UI title bar with format: "ibtop - InfiniBand Monitor @ {hostname}"
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps version to 0.1.6 and adds hostname = "0.4" dependency |
| Cargo.lock | Updates lock file with hostname crate and its transitive dependencies (cfg-if, libc, windows-link) |
| src/types.rs | Introduces IbtopOutput struct to wrap hostname and adapter data for JSON output |
| src/main.rs | Retrieves hostname in JSON mode and wraps output with new IbtopOutput struct |
| src/ui.rs | Adds hostname to UI title bar by calling hostname::get() during each frame render |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ibtop - InfiniBand Monitor @ {hostname}hostnamecrate as dependencyCloses #8
Test plan
IBTOP_FAKE_DATA=1 cargo run -- --jsonand verify hostname appears in JSON outputIBTOP_DEMO=1 cargo runand verify hostname appears in title bar