Skip to content

fix utilization calc for full-duplex links #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JannikSt merged 2 commits into from
Dec 30, 2025
Merged

fix utilization calc for full-duplex links #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b72dad
fix utilization calc for full-duplex links
JannikSt Dec 30, 2025
043b1e5
fmt
JannikSt Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,10 @@ fn draw_main_table(
};

// Throughput bar (visual indicator of utilization)
// InfiniBand is full-duplex, so we use max(RX, TX) not sum
let utilization = if let Some(m) = port_metrics {
let max_rate = parse_max_rate(&port.rate);
let current_rate = m.rx_bytes_per_sec + m.tx_bytes_per_sec;
let current_rate = m.rx_bytes_per_sec.max(m.tx_bytes_per_sec);
(current_rate / max_rate * 100.0).min(100.0)
} else {
0.0
Expand Down Expand Up @@ -695,13 +696,12 @@ fn render_utilization_bar(percent: f64, width: usize) -> String {

/// Parse max rate from rate string (e.g., "100 Gb/sec" -> bytes/sec)
fn parse_max_rate(rate_str: &str) -> f64 {
// Extract the number and unit
let parts: Vec<&str> = rate_str.split_whitespace().collect();
if parts.len() >= 2 {
if let Ok(num) = parts[0].parse::<f64>() {
// Convert Gb/sec to bytes/sec
return num * 1_000_000_000.0 / 8.0;
}
// Extract numeric value from rate string
// Handles formats like "400 Gb/sec", "400Gb/sec", "400 Gb/sec (4X NDR)"
let num_str: String = rate_str.chars().take_while(char::is_ascii_digit).collect();
if let Ok(num) = num_str.parse::<f64>() {
// Convert Gb/sec to bytes/sec
return num * 1_000_000_000.0 / 8.0;
}
// Default to 100 Gbps
12_500_000_000.0
Expand Down Expand Up @@ -802,7 +802,11 @@ mod tests {
#[test]
fn test_parse_max_rate() {
assert!((parse_max_rate("100 Gb/sec (4X EDR)") - 12_500_000_000.0).abs() < 1.0);
assert!((parse_max_rate("100 Gb/sec (2X HDR)") - 12_500_000_000.0).abs() < 1.0);
assert!((parse_max_rate("200 Gb/sec") - 25_000_000_000.0).abs() < 1.0);
assert!((parse_max_rate("400 Gb/sec (4X NDR)") - 50_000_000_000.0).abs() < 1.0);
assert!((parse_max_rate("800 Gb/sec (4X XDR)") - 100_000_000_000.0).abs() < 1.0);
assert!((parse_max_rate("800Gb/sec") - 100_000_000_000.0).abs() < 1.0); // No space
assert!((parse_max_rate("invalid") - 12_500_000_000.0).abs() < 1.0); // Default
}

Expand Down
Loading