Fix type of SRV target

[rossabaker]

The target type of an SRV record should be a hostname, not an int.

[rossabaker]

Is it unidiomatic to set an SRV record in networking.domains.subDomains? That's how I hit the type error. It's already fine if it's defined in extraConfig, which is covered by a unit test.

[Janik-Haag]

Uh thanks, I missed that. I'll take a look later

Is it unidiomatic to set an SRV record in networking.domains.subDomains?

No should be fine, I just didn't have a usecase yet.

That's how I hit the type error. It's already fine if it's defined in extraConfig, which is covered by a unit

Oh I thought so to but it's in fact not, because the attrset in utils/tests/zonefiles.nix is not the one passed to extraConfig but instead the a value of any key utils.domains.getDns would return. Did you actually try with extraConfig, I believe you should run into the same error because it is supposed to do the type-checking as well. I'll add a unit test checking both all record types for extraConfig and the nixosConfigurations.

I have to had of to $dayjob now, but I'll take a closer look in ~9-10 hours.

[rossabaker]

Did you actually try with extraConfig,

I was sleepy and must have tried it against the corrected branch. I've added an example to the tests, which failed with the type error on target before the fix.

I'll add a unit test checking both all record types for extraConfig and the nixosConfigurations.

I haven't gone as far as this yet, but it's a good idea.