Open
Conversation
- src/biz_layer/mem_db_operations.py: line 146 - src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.py: line 127 - tests/test_conv_memcell_extractor.py: line 40 - tests/test_group_user_profile_memory_raw_repository.py: line 531 Bare except: catches BaseException including KeyboardInterrupt and SystemExit. Using except Exception: preserves fallback behavior while allowing system exceptions to propagate. Ref: Issue EverMind-AI#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
I found and fixed issue EverMind-AI#98 - replacing bare
except:withexcept Exception:.Changes Made
Four files modified:
src/biz_layer/mem_db_operations.py: line 146src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.py: line 127tests/test_conv_memcell_extractor.py: line 40tests/test_group_user_profile_memory_raw_repository.py: line 531Why
Bare
except:catchesBaseExceptionincludingKeyboardInterruptandSystemExit. Usingexcept Exception:preserves the fallback error-handling behavior while allowing system exceptions to propagate.Reference: Issue EverMind-AI#98
Local Testing
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。
Warmly,