This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
Update EN translations #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preliminary work
|
Custom notification sound works when duty matched too. So "ui-setting-fatesound" and "ui-setting-customsound" text should be changed. fatesound option disables custom sound on fate. but custom sound works on duty matches. |
|
I think UI is some confusing, so I'm planning to change custom sound option divided to FATE and duty. |
|
Yeah, I was a little confused with the wording on custom sounds. I will update the translations later today! I'll also gladly work with any future changes you make 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my work so far of tidying up the English translations so they sound a bit more natural