fix(sim): exit 1 on unknown AUTOPILOT in analyze_logs.sh#166
Closed
Bartok9 wants to merge 1 commit into
Closed
Conversation
Treat an unrecognized AUTOPILOT value as a hard failure instead of exiting 0 so callers cannot miss a misconfigured analysis run. Signed-off-by: Daniel Pike <daniel@team-of-light.org>
Owner
|
@Bartok9 while all contributions are welcome, including AI assisted ones, at most one per day, with at most ~50/100 changes that are either (1) a genuine fix of something broken or a (2) meaningful/desirable new functionality are acceptable. |
Contributor
Author
|
Thanks @JacopoPan, and apologies for the noise — completely understood. I'll respect the cadence: at most one contribution per day, scoped to a genuine fix of something broken or meaningful new functionality (~50–100 lines), not micro-hardening like this. Appreciate you spelling out the bar clearly; I'll keep future PRs to that standard. Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Success exit on unknown autopilot hides operator misconfig in automation. Mirror the existing NUM_DRONES fail-closed path.
Verification
`bash -n simulation/simulation_resources/scripts/analyze_logs.sh`
`AUTOPILOT=bogus NUM_QUADS=1 NUM_VTOLS=0 NUM_TAILS=0 bash .../analyze_logs.sh` → exit 1
Did NOT change: sim_run/sim_build/deploy_* env validation (maintainer check_env_vars), geofence/arm paths
Notes
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h