fix(ground): safe non-negative int parse for DTC drone counts#165
Closed
Bartok9 wants to merge 2 commits into
Closed
fix(ground): safe non-negative int parse for DTC drone counts#165Bartok9 wants to merge 2 commits into
Bartok9 wants to merge 2 commits into
Conversation
Reject empty/signed/decimal env values for NUM_QUADS/VTOLS/TAILS before building expected drone id lists; add offline unit tests. Signed-off-by: Daniel Pike <daniel@team-of-light.org>
ruff F401 on dtc_controller_node after moving NUM_* reads to parse_nonneg_int_env. Signed-off-by: Daniel Pike <daniel@team-of-light.org> Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Bare `int(os.environ.get(...))` raises on empty/garbage env and accepts negatives. Fail closed with defaults only for missing keys.
Verification
`cd ground/ground_ws/src/drone_traffic_controller && PYTHONPATH=. python3 -m unittest drone_traffic_controller.test_count_env -v` → 4 passed
Did NOT change: sim_run/sim_build/deploy_* env validation (maintainer check_env_vars), geofence/arm paths
Notes
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h