fix(ground): validate UDP port and window name for GStreamer receiver#161
Closed
Bartok9 wants to merge 1 commit into
Closed
fix(ground): validate UDP port and window name for GStreamer receiver#161Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Add pure validators (1..65535 port, non-empty name) with offline unit tests and fail closed in the receiver CLI before opening the pipeline. Signed-off-by: Daniel Pike <daniel@team-of-light.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Invalid ports/empty names currently reach the GStreamer pipeline string and fail obscurely. Validate early with unit coverage.
Verification
`cd ground/ground_resources/comms && python3 -m unittest test_udp_gst_validate -v` → 4 passed
Did NOT change: sim_run/sim_build/deploy_* env validation (maintainer check_env_vars), geofence/arm paths
Notes
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h