Skip to content

test(mission): allowlist helper for known mission leaf actions#160

Closed
Bartok9 wants to merge 1 commit into
JacopoPan:mainfrom
Bartok9:test/mission-known-actions
Closed

test(mission): allowlist helper for known mission leaf actions#160
Bartok9 wants to merge 1 commit into
JacopoPan:mainfrom
Bartok9:test/mission-known-actions

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extract `KNOWN_ACTIONS` + `is_known_action` and cover with offline unittest; tree_builder uses the helper.

Motivation

Unknown leaf actions already become Failure nodes, but the allowlist was implicit. A pure helper makes the contract testable without ROS/py_trees runtime deps on the helper itself.

Verification

  • `cd aircraft/aircraft_ws/src/mission && PYTHONPATH=. python3 -m unittest mission.test_mission_actions -v` → 3 passed

  • Did NOT change: sim_run/sim_build/deploy_* env validation (maintainer check_env_vars), geofence/arm paths

Notes

  • One logical change; minimal additive diff
  • Human-authored and reviewed; AI-assisted drafting only where noted in campaign process
  • DCO signed-off

Agent-Owner: sera · Platform: hermes · Claim-TTL: 24h

Export KNOWN_ACTIONS for offline unit tests and distinguish unknown
names from unhandled known branches in tree_builder.

Signed-off-by: Daniel Pike <daniel@team-of-light.org>
@JacopoPan JacopoPan closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants