fix(aircraft): guard short argv in cancellable action client#159
Closed
Bartok9 wants to merge 1 commit into
Closed
fix(aircraft): guard short argv in cancellable action client#159Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Avoid IndexError when the quoted ros2 action send_goal command has fewer than 6 tokens. Signed-off-by: Daniel Pike <daniel@team-of-light.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Short argv currently raises IndexError on `parts[3:6]`. Fail with a usage message instead of a traceback.
Verification
`python3 -m py_compile aircraft/aircraft_resources/patches/cancellable_action.py`
Did NOT change: sim_run/sim_build/deploy_* env validation (maintainer check_env_vars), geofence/arm paths
Notes
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h