fix(sim): require positive finite --step_sec for gz_step#157
Closed
Bartok9 wants to merge 1 commit into
Closed
Conversation
Refuse missing/non-finite/non-positive step lengths and unknown AUTOPILOT values before calling Gazebo WorldControl. Signed-off-by: Daniel Pike <daniel@team-of-light.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Missing or non-finite step lengths and unknown autopilot strings currently fall through to int conversion / unbounded multi_step. Fail closed with a clear CLI error before touching the sim.
Verification
`python3 -m py_compile simulation/simulation_resources/scripts/gz_step.py`
Manual review of argparse guard path (no Gazebo on Mac host)
Did NOT change: sim_run/sim_build/deploy_* env validation (maintainer check_env_vars), geofence/arm paths
Notes
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h