Add a new parseJabRefComment with unit test #12145
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
fix logic check string contains a valid json
There was a problem hiding this comment.
Please do differently.
I highlighted the idea using the diff:
Check for jabref-meta-0.1.0string at the beginning of the comment. Then remove that line. The remainder of the comment is the complete JSON.
Do NOT read the JSON as BibEntry. It is NOT a BibEntry. It is META data for JabRef. E.g., preferences etc.
Background: JabRef displys BibEntrys in the main table - and settings in dialog. We do not render settings in the main table.
| } catch ( | ||
| JsonSyntaxException e) { |
There was a problem hiding this comment.
Checkstyle is somewhat broken, please reduce to one line.
1. read json as metadata 2. small refactor to remove a not in use `LOGGER` in `MetaData`
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
| @@ -339,7 +342,7 @@ private void parseAndAddEntry(String type) { | |||
| } | |||
| } | |||
|
|
|||
| private void parseJabRefComment(Map<String, String> meta) { | |||
| void parseJabRefComment(Map<String, String> meta) { | |||
| } | ||
| } | ||
|
|
||
| private void parseCommentToJson(String comment, Map<String, String> meta) { |
There was a problem hiding this comment.
No - it should return the JSOn object.
The following call should be rewritten:
MetaData metaData = metaDataParser.parse(
meta,
importFormatPreferences.bibEntryPreferences().getKeywordSeparator());meta should be a record of
Map<String, String> v5metaDataJsonObject v6metaData
And then be handled accordingliny in org.jabref.logic.importer.fileformat.BibtexParser#metaDataParser.
|
|
||
| @AllowedToUseLogic("because it needs access to citation pattern and cleanups") | ||
| public class MetaData { | ||
|
|
||
| public static final String META_FLAG = "jabref-meta: "; | ||
| public static final String META_FLAG_010 = "jabref-meta-0.1.0"; |
There was a problem hiding this comment.
Include the string Version in the constant name:
| public static final String META_FLAG_010 = "jabref-meta-0.1.0"; | |
| public static final String META_FLAG_VERSION_010 = "jabref-meta-0.1.0"; |
rewrite metaDataParser.parse
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
fix wrong input
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)