Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scrollable warning messages in alert boxes #10700

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Conversation

garymejia
Copy link
Contributor

@garymejia garymejia commented Dec 14, 2023

Added a scrollbar to the "Open library error" popup window to prevent extension beyond the screen when handling large bib files with citation errors. This enhancement ensures the window remains within the screen boundaries.
Closes #10674

WarningScroll

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking initiative! - Please ensure that you have JabRef's code style settings in place. Checkstyle complains about wrong import order.

I wonder whether there can be tests added?

At least for getErrorMessages() there should be a test.

Reason: This is a logic module - and one or more tests can help enhancing that core funtionality.

@garymejia
Copy link
Contributor Author

I'll work on getting a test setup soon. Let me know if I committed incorrectly. Still trying to get a hang of this haha.

@koppor koppor added this pull request to the merge queue Dec 18, 2023
@koppor
Copy link
Member

koppor commented Dec 18, 2023

@garymejia Thank you for the PR. We will merge it. You can add test cases as a follow-up if you want!

Merged via the queue into JabRef:main with commit 2bed3d3 Dec 18, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window "Open library error" too large for the screen
3 participants