Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update because Dubtrack removed jQuery #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FranciscoG
Copy link

  • added an extra pre-step which loads jQuery from a CDN and then kicks off index.js
  • made webpack a dev dependency of the project and using the latest version
  • added webpack-cli because it was a required peer dependency of newer webpack
  • livescript-loader did not work with the latest webpack so removed it and added livescript as a dev dependency and compiling before using webpack (see package.json script)
  • updated webpack config because of the above reasons
  • found a better maintained version of FileSaver.js. It wasn't working but now it is

you can test it out by creating a bookmark pointing to my repo:
javascript:(function(d){var s=d.createElement('script');s.src="https://raw.githack.com/FranciscoG/Dubtrack-Playlist-Pusher/jquery-cdn/index.js";d.body.appendChild(s)})(document);void(8)

note

if you do merge you'll need to update your bookmarklet example to remove the jQuery and use the same pure js in my test example

…st, removed outdated livescript-loader and made livescript a local dev dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant