Skip to content

Commit

Permalink
add missin build tags
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgemmsilva committed Oct 22, 2021
1 parent b3a4c90 commit 70a0dfe
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
run: make build

- name: Test
run: go test -tags rocksdb -v -short -failfast ./...
run: go test -tags rocksdb,builtin_static -v -short -failfast ./...

golangci:
name: lint
Expand Down
2 changes: 1 addition & 1 deletion documentation/docs/contribute.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Before creating the Pull Request ensure that:
- all the tests pass:

```bash
go test -tags rocksdb ./...
go test -tags rocksdb,builtin_static ./...
```

- there are no linting violations (instructions on how to setup linting below):
Expand Down
4 changes: 2 additions & 2 deletions documentation/docs/guide/chains_and_nodes/running-a-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin
You can run integration and unit test together with the following command:

```bash
go test -tags rocksdb -timeout 20m ./...
go test -tags rocksdb,builtin_static -timeout 20m ./...
```
Keep in mind that this process may take several minutes.

Expand All @@ -97,7 +97,7 @@ Keep in mind that this process may take several minutes.
You can run the unit tests without running integration tests with the following command:

```bash
go test -tags rocksdb -short ./...
go test -tags rocksdb,builtin_static -short ./...
```

This will take significantly less time than [running all tests](#run-all-tests).
Expand Down
2 changes: 1 addition & 1 deletion documentation/docs/misc/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ docker build -t wasp-node .

The build process will copy the docker_config.json file into the image, which will use it when the node gets started.

By default, the build process will use `-tags rocksdb` as a build argument. This argument can be modified with `--build-arg BUILD_TAGS=<tags>`.
By default, the build process will use `-tags rocksdb,builtin_static` as a build argument. This argument can be modified with `--build-arg BUILD_TAGS=<tags>`.

Depending on the use case, Wasp requires a different GoShimmer hostname which can be changed at this part inside the [docker_config.json](https://github.com/iotaledger/wasp/blob/develop/docker_config.json) file:

Expand Down
2 changes: 1 addition & 1 deletion documentation/docs/misc/runwasp.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Docker.
```
$ git clone https://github.com/iotaledger/goshimmer.git
$ cd goshimmer
$ go install -tags rocksdb
$ go install -tags rocksdb,builtin_static
```

Then, create an empty working directory for Goshimmer, and download the
Expand Down
4 changes: 2 additions & 2 deletions documentation/docs/welcome.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin

## Test

- Run all tests (including integration tests which may take several minutes): `go test -tags rocksdb -timeout 20m ./...`
- Run only unit tests: `go test -tags rocksdb -short ./...`
- Run all tests (including integration tests which may take several minutes): `go test -tags rocksdb,builtin_static -timeout 20m ./...`
- Run only unit tests: `go test -tags rocksdb,builtin_static -short ./...`

Note: integration tests require the `wasp` and `wasp-cli` commands
in the system path (i.e. you need to run `go install ./...` before running
Expand Down
2 changes: 1 addition & 1 deletion tools/monitoring/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ RUN go mod download

COPY . ./

RUN go build -tags rocksdb
RUN go build -tags rocksdb,builtin_static

FROM gcr.io/distroless/cc

Expand Down

0 comments on commit 70a0dfe

Please sign in to comment.