Skip to content

Add remote repository URL #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JSTONE1111 wants to merge 4 commits into
base: develop
Choose a base branch
from
+19 −1
Open

Add remote repository URL #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b705464
Create xrp package json
JSTONE1111 Oct 22, 2025
096dfda
Modify build dependencies step in windows.yml
JSTONE1111 Dec 17, 2025
fb81f87
Add remote repository URL
JSTONE1111 Feb 2, 2026
27a283f
Merge pull request #1 from JSTONE1111/JSTONE1111-patch-2
JSTONE1111 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ jobs:
echo "Added conan remote ripple at ${CONAN_URL}"
- name: build dependencies
uses: ./.github/actions/dependencies
with:
with:[![levelization](https://github.com/JSTONE1111/rippled/actions/workflows/levelization.yml/badge.svg)](https://github.com/JSTONE1111/rippled/actions/workflows/levelization.yml)

configuration: ${{ matrix.configuration.type }}
Comment on lines +105 to 107
Copy link

@coderabbitai coderabbitai bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Malformed YAML breaks the entire Windows CI workflow.

Line 105 replaces the valid with: mapping with a Markdown badge link, producing invalid YAML. The actionlint static analysis tool also flags this: could not parse as YAML: could not find expected ':'. This will prevent the workflow from being parsed by GitHub Actions, so no Windows CI jobs will run.

🐛 Proposed fix — restore valid YAML 
-        with:[![levelization](https://github.com/JSTONE1111/rippled/actions/workflows/levelization.yml/badge.svg)](https://github.com/JSTONE1111/rippled/actions/workflows/levelization.yml)
-        
+        with:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
with:[![levelization](https://github.com/JSTONE1111/rippled/actions/workflows/levelization.yml/badge.svg)](https://github.com/JSTONE1111/rippled/actions/workflows/levelization.yml)
configuration: ${{ matrix.configuration.type }}
with:
configuration: ${{ matrix.configuration.type }}
🧰 Tools
🪛 actionlint (1.7.10)

[error] 105-105: could not parse as YAML: could not find expected ':'

(syntax-check)

🪛 YAMLlint (1.38.0)

[error] 107-107: syntax error: could not find expected ':'

(syntax)

🤖 Prompt for AI Agents 
In @.github/workflows/windows.yml around lines 105 - 107, The workflow YAML was
corrupted by inserting a Markdown badge where the `with:` mapping belongs;
revert that line so `with:` is a proper mapping key and ensure `configuration:
${{ matrix.configuration.type }}` is indented under it (i.e., put `with:` on its
own line and follow with the `configuration:` entry as a child of `with:`).
Remove the markdown badge text entirely from this block and restore the original
mapping structure so actionlint/GitHub can parse the workflow.

- name: build
uses: ./.github/actions/build
Expand Down
1 change: 1 addition & 0 deletions git@github.com:JSTONE1111/rippled.git
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
git@github.com:JSTONE1111/rippled.git
Copy link

@coderabbitai coderabbitai bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Remove this file — it serves no purpose and appears to be an accidental commit.

A file whose name and sole content is a git SSH remote URL (git@github.com:JSTONE1111/rippled.git) does not belong in the repository. This looks like an accident (e.g., a shell redirect or mistyped command).

🤖 Prompt for AI Agents 
In `@git`@github.com:JSTONE1111/rippled.git at line 1, Delete the accidental file
whose entire content is the single string
"git@github.com:JSTONE1111/rippled.git": remove it from the working tree and
commit the deletion (git rm <file>; git commit -m "Remove accidental git URL
file"); if the file was part of a pushed commit and must be purged from history,
use an interactive rebase or git filter-repo to remove it and force-push the
cleaned branch; optionally add a .gitignore entry to prevent re-adding such
stray files.

16 changes: 16 additions & 0 deletions xrp package json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"name": "xrpl-dev-boilerplate",
"version": "1.0.0",
"description": "XRPL dev boilerplate — wallet generation, balance, payment example (Testnet)",
"main": "index.js",
"scripts": {
"start": "node index.js",
"dev": "NODE_ENV=development nodemon index.js"
},
"dependencies": {
"body-parser": "^1.20.2",
"dotenv": "^16.3.1",
"express": "^4.18.2",
"xrpl": "^4.4.0"
}
}
Comment on lines +1 to +16
Copy link

@coderabbitai coderabbitai bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

This package.json does not belong in the rippled repository.

rippled is a C++ implementation of the XRP Ledger server. A Node.js boilerplate project (xrpl-dev-boilerplate) with Express/body-parser/dotenv dependencies is unrelated and should not be added to this repository. There is also no corresponding index.js or any application code in this PR.

Additionally, the dev script references nodemon but it is not listed in dependencies or devDependencies.

🤖 Prompt for AI Agents 
In `@xrp` package json around lines 1 - 16, This package.json (project name
"xrpl-dev-boilerplate") doesn't belong in the rippled repo; remove the added
package.json file from the PR and any unrelated Node.js boilerplate artifacts
(references to index.js, scripts.start, scripts.dev, and dependencies like
express/body-parser/dotenv/xrpl). If you actually intend to add a Node project,
move this package.json into the correct separate repository and ensure
scripts.dev references nodemon only if nodemon is declared in devDependencies;
otherwise add nodemon to devDependencies. Ensure no stray Node files remain in
the rippled changeset.

Loading