fix(content-lane): harden duplicates block-scalar header detection#9358
fix(content-lane): harden duplicates block-scalar header detection#9358joaovictor91123 wants to merge 1 commit into
Conversation
Mirror source-evidence.ts block-scalar grammar so chomping/indent permutations and trailing inline comments are recognized in parseSimpleFrontmatter and findDuplicateFrontmatterKeys. Closes JSONbored#9290
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-27 14:19:19 UTC
Review summary Nits — 4 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
src/review/content-lane/duplicates.tsto match the grammar already used insource-evidence.ts(stripYamlComment,BLOCK_SCALAR_INDICATOR,isBlockScalarHeader)./^[|>][+-]?\d*$/checks inparseSimpleFrontmatterandfindDuplicateFrontmatterKeysso chomping/indent permutations (|2-,>2+, etc.) and trailing inline comments (| # note) are recognized.content-lane-source-evidence.test.ts.Closes #9290
Scope
duplicates.ts+content-lane-duplicates.test.ts(scoped CI should stay ~1 test file, same shape as merged fix(signals): render discouragedPaths in onboarding-pack preview markdown #9336 / test(signals): cover buildReviewRiskExplanation's 5-way branch logic (#9287) #9338).processors.ts,advisory.ts) that fan out to thousands of tests and hit maintainer fix: close the remaining 5 pre-existing test failures on main #9285 flake.Validation
--changedselection (not the fix: close the remaining 5 pre-existing test failures on main #9285selfhost-pg-retention/salvageabilityslice).