Skip to content

test(miner): rename miner-cli-json-error-coverage.test.ts to drop the coverage-padding filename #8585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 24, 2026
+6 −1
Merged

test(miner): rename miner-cli-json-error-coverage.test.ts to drop the coverage-padding filename #8585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...nit/miner-cli-json-error-coverage.test.ts → test/unit/miner-cli-json-error-paths.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ async function expectJsonErrorAsync(
stderr.mockRestore();
}

describe("miner CLI --json error coverage (#4836)", () => {
// Shared --json error-envelope contract across the miner CLI's subcommands (#4836): every run* entry
// point must fail with { ok: false, error: string } on stdout, exit code 2, and nothing on stderr.
// Grouped by CLI surface (not split per-sibling file) because the thing under test IS the shared
// envelope, exercised via expectJsonError/expectJsonErrorAsync above -- splitting it apart would
// duplicate that helper and lose the "one contract, many entry points" narrative.
describe("miner CLI --json error paths (#4836)", () => {
it("portfolio queue list/next/done/claim-batch failures", () => {
expectJsonError(() => runQueueList(["--verbose", "--json"]), /Unknown option/);
expectJsonError(
Expand Down