test(signals): fold reward-risk-engine-branch-coverage.test.ts into its siblings#8582
Merged
Merged
Conversation
…ts siblings (#8578) reward-risk-engine-branch-coverage.test.ts was a #2281 Codecov bolt-on testing buildRepoRewardRisk / rewardRiskFreshnessInternals / buildContributorRewardRiskStrategy from its own disconnected file. Move each case to the sibling that already owns the function under test: - bestFitLabels tie-break -> reward-risk-freshness.test.ts's existing "bestFitLabels keyword anchoring" describe (reused its pick() idiom) - reviewChurnRisk (high/medium) + maintainer-cut readiness -> reward-risk-freshness.test.ts, new describe block (buildRepoRewardRisk) - buildContributorRewardRiskStrategy tie-break -> reward-risk-reports.test.ts, new describe block (the only reward-risk sibling besides the signals-v2/ signals-coverage family, which stays out of scope per #8574/#8576) Verified zero coverage regression: packages/loopover-engine/src/reward-risk.ts (259/303 branches, 152/164 lines) and packages/loopover-engine/src/signals/engine.ts (441/1973 branches, 437/1351 lines) are identical before and after.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8582 +/- ##
==========================================
- Coverage 92.54% 91.99% -0.56%
==========================================
Files 796 796
Lines 79845 79845
Branches 24134 24134
==========================================
- Hits 73896 73452 -444
- Misses 4802 5309 +507
+ Partials 1147 1084 -63
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8578.
Summary
reward-risk-engine-branch-coverage.test.tswas a #2281 Codecov bolt-on testingbuildRepoRewardRisk/rewardRiskFreshnessInternals/buildContributorRewardRiskStrategyfrom its own disconnected file. Moved each case to the sibling that already owns the function under test:reward-risk-freshness.test.ts's existingbestFitLabels keyword anchoringdescribe (reused itspick()idiom)reviewChurnRisk(high/medium) + maintainer-cut readiness ->reward-risk-freshness.test.ts, new describe blockbuildContributorRewardRiskStrategytie-break ->reward-risk-reports.test.ts, new describe block (the only reward-risk sibling besides the signals-v2/signals-coverage family, which stays out of scope here per Epic: consolidate the '-coverage' bolt-on test-file family #8574/Consolidate signals-coverage.test.ts into the signals main suites #8576)Test plan
npx vitest run test/unit/reward-risk-freshness.test.ts test/unit/reward-risk-reports.test.ts test/unit/reward-risk-competition-fail-closed.test.ts— 34/34 passnpm run typecheck— cleanpackages/loopover-engine/src/reward-risk.ts: 259/303 branches (85.47%), 152/164 lines (92.68%)packages/loopover-engine/src/signals/engine.ts: 441/1973 branches (22.35%), 437/1351 lines (32.34%)