Skip to content

fix(config-lint): recognize fairnessAnalytics as a top-level field #8406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 24, 2026
+11 −0
Merged

fix(config-lint): recognize fairnessAnalytics as a top-level field #8406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/loopover-engine/src/config-lint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const TOP_LEVEL_FIELDS = [
"activeReviewReconciliation",
"loopEscalation",
"federatedIntelligence",
"fairnessAnalytics",
] as const;

const TOP_LEVEL_FIELD_SET = new Set<string>(TOP_LEVEL_FIELDS);
Expand Down
10 changes: 10 additions & 0 deletions test/unit/selfhost-config-lint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,16 @@ reviewRecap:
expect(result.recognizedFields).toEqual(["experimental"]);
});

it("REGRESSION: recognizes a standalone fairnessAnalytics: block instead of flagging it as unknown (#8365)", () => {
// fairnessAnalytics is fully parsed by focus-manifest.ts but was missing from TOP_LEVEL_FIELDS,
// so operators got a spurious unknown-field warning for a supported config-as-code block.
const result = lintManifestText("fairnessAnalytics:\n enabled: true\n");

expect(result.ok).toBe(true);
expect(result.warnings).toEqual([]);
expect(result.recognizedFields).toEqual(["fairnessAnalytics"]);
});

it("recognizes a standalone reviewRecap: block instead of flagging it as unknown (#1963)", () => {
const result = lintManifestText("reviewRecap:\n enabled: true\n cadenceDays: 14\n");

Expand Down