test(engine): cover reviewer-consensus-calibration under root vitest#8399
Conversation
…SONbored#8349) The engine package already had a full node:test suite for this module, but Codecov's codecov/patch gate only reads root vitest coverage — so the package's largest branch surface (~128 branches) reported ~0% despite real tests one directory over. Mirror every existing scenario (plus remaining branch edges) into test/unit/ so the file reaches 100% line/branch coverage under npm run test:coverage. No source or package-test changes. Also note the root vitest mirror in packages/loopover-engine/README.md so the engine path filter selects the unscoped CI suite (a test-only diff under --changed currently writes empty lcov and trips validate-tests-merge).
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8399 +/- ##
==========================================
+ Coverage 92.17% 92.41% +0.23%
==========================================
Files 791 791
Lines 79249 79249
Branches 23947 23945 -2
==========================================
+ Hits 73048 73238 +190
+ Misses 5062 4868 -194
- Partials 1139 1143 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-24 11:39:26 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
What
packages/loopover-engine/src/reviewer-consensus-calibration.ts(658 lines, ~128 branches) already had a full, passingnode:testsuite one directory over — but Codecov'scodecov/patchgate only reads root vitest coverage, so the package's largest branch surface reported ~0% despite real tests. Same blind-spot class as #6250.Changes
test/unit/reviewer-consensus-calibration.test.ts(vitest), importing the four public APIs from the engine barrel — matching thetest/unit/calibration-dashboard.test.tspattern.packages/loopover-engine/test/reviewer-consensus-calibration.test.ts, plus remaining branch edges, so the module hits 100% statements/branches/functions/lines undernpm run test:coverage.packages/loopover-engine/src/**orpackages/loopover-engine/test/**.packages/loopover-engine/README.md(also trips theengineCI path filter so this PR runs the unscoped suite — a test-only diff under scoped--changedcurrently writes emptylcovand failsvalidate-tests-merge).Closes
Closes #8349
Verification
npx vitest run test/unit/reviewer-consensus-calibration.test.ts— 23 passedpackages/loopover-engine/src/reviewer-consensus-calibration.ts— 100% stmts/branches/funcs/linesengine=trueand the full suite runs.