fix(mcp): align read report tools with requireRepoAccess

src/mcp/server.ts

@@ -3456,8 +3456,10 @@ export class LoopoverMcp {
   }
 
   private async getMaintainerNoise(input: { owner: string; repo: string }): Promise<ToolPayload> {
+    // (#8338) Mirrors GET /v1/repos/:owner/:repo/maintainer-noise: same requireRepoAccess gate as sibling
+    // read-only maintainer reports (and REST requireRepoMaintainer) — not the live-write approval-queue gate.
     const fullName = `${input.owner}/${input.repo}`;
-    await this.requireRepoApprovalQueueAccess(fullName);
+    await this.requireRepoAccess(fullName);
     const report = await loadMaintainerNoiseReport(this.env, fullName);
     return {
       summary: maintainerNoiseSummary(report),
@@ -3466,10 +3468,11 @@ export class LoopoverMcp {
   }
 
   private async getAmsMinerCohort(input: { owner: string; repo: string }): Promise<ToolPayload> {
-    // Mirrors GET /v1/repos/:owner/:repo/ams-miner-cohort: same maintainer gate as getMaintainerNoise
-    // (requireRepoApprovalQueueAccess) and the same buildAmsMinerCohortComparison service the REST route uses.
+    // (#8338) Mirrors GET /v1/repos/:owner/:repo/ams-miner-cohort: same requireRepoAccess gate as
+    // getMaintainerNoise / other read-only maintainer reports, and the same buildAmsMinerCohortComparison
+    // service the REST route uses.
     const fullName = `${input.owner}/${input.repo}`;
-    await this.requireRepoApprovalQueueAccess(fullName);
+    await this.requireRepoAccess(fullName);
     const report = await buildAmsMinerCohortComparison(this.env, fullName);
     // Single summary template (no present-branch) so patch coverage stays complete under the 99% gate; the
     // structured payload still carries `present` for clients that need the empty vs populated distinction.
@@ -3492,12 +3495,13 @@ export class LoopoverMcp {
     };
   }
 
-  // (#7799) MCP surface for GET /v1/repos/:owner/:repo/activation-preview. Assembles the same inputs the REST
+  // (#7799/#8338) MCP surface for GET /v1/repos/:owner/:repo/activation-preview. Same requireRepoAccess gate
+  // as sibling read-only maintainer reports (REST requireRepoMaintainer). Assembles the same inputs the REST
   // route does (getRepository + resolveRepositorySettings + listPullRequests) and defers to the guarded
   // buildMaintainerActivationPreview service. Deterministic and advisory-only -- never runs AI.
   private async getActivationPreview(input: { owner: string; repo: string }): Promise<ToolPayload> {
     const fullName = `${input.owner}/${input.repo}`;
-    await this.requireRepoApprovalQueueAccess(fullName);
+    await this.requireRepoAccess(fullName);
     const [repo, settings, pullRequests] = await Promise.all([
       getRepository(this.env, fullName),
       resolveRepositorySettings(this.env, fullName),

test/unit/mcp-read-report-gate-parity.test.ts

@@ -0,0 +1,104 @@
+import { Client } from "@modelcontextprotocol/sdk/client/index.js";
+import { InMemoryTransport } from "@modelcontextprotocol/sdk/inMemory.js";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { LoopoverMcp } from "../../src/mcp/server";
+import { getRepositoryCollaboratorPermission } from "../../src/github/app";
+import { upsertInstallation, upsertPullRequestFromGitHub, upsertRepositoryFromGitHub } from "../../src/db/repositories";
+import type { AuthIdentity } from "../../src/auth/security";
+import { createTestEnv } from "../helpers/d1";
+
+// #8338: getMaintainerNoise / getAmsMinerCohort / getActivationPreview must use requireRepoAccess
+// (cached maintainer/owner/operator scope), matching their REST mirrors and sibling read tools — not the
+// live-write requireRepoApprovalQueueAccess gate reserved for approval-queue / write tools.
+
+vi.mock("../../src/github/app", async (importOriginal) => ({
+  ...(await importOriginal<typeof import("../../src/github/app")>()),
+  getRepositoryCollaboratorPermission: vi.fn(),
+  createInstallationToken: vi.fn(async () => "test-installation-token"),
+}));
+
+const mockedPermission = vi.mocked(getRepositoryCollaboratorPermission);
+
+const READ_REPORT_TOOLS = ["loopover_get_maintainer_noise", "loopover_get_ams_miner_cohort", "loopover_get_activation_preview"] as const;
+
+beforeEach(() => {
+  mockedPermission.mockReset();
+  // Fail closed on live collaborator lookup — the regression is that these three tools used to deny
+  // when this failed even though cached maintainer scope was enough for every sibling read tool.
+  mockedPermission.mockRejectedValue(new Error("github collaborator lookup unavailable"));
+});
+
+async function connect(env: Env, identity?: AuthIdentity) {
+  const server = (identity ? new LoopoverMcp(env, identity) : new LoopoverMcp(env)).createServer();
+  const [clientTransport, serverTransport] = InMemoryTransport.createLinkedPair();
+  await server.connect(serverTransport);
+  const client = new Client({ name: "loopover-read-report-gate-test", version: "0.1.0" }, { capabilities: {} });
+  await client.connect(clientTransport);
+  return client;
+}
+
+async function seedOwnedRepo(env: Env): Promise<void> {
+  await upsertInstallation(env, {
+    installation: {
+      id: 5,
+      account: { login: "owner", id: 1, type: "User" },
+      repository_selection: "selected",
+      permissions: { metadata: "read", contents: "read", pull_requests: "read", issues: "read" },
+      events: ["pull_request"],
+    },
+    repositories: [{ name: "repo", full_name: "owner/repo", private: false, owner: { login: "owner" } }],
+  });
+  await upsertRepositoryFromGitHub(env, { name: "repo", full_name: "owner/repo", private: false, owner: { login: "owner" } }, 5);
+}
+
+describe("MCP read-only maintainer report gate parity (#8338)", () => {
+  it("REGRESSION (#8338): cached maintainer scope succeeds even when live collaborator lookup fails", async () => {
+    const env = createTestEnv();
+    await seedOwnedRepo(env);
+    // Cached COLLABORATOR association grants maintainer scope via canLoginAccessRepo / requireRepoAccess,
+    // but is intentionally insufficient for requireRepoApprovalQueueAccess (live write required).
+    await upsertPullRequestFromGitHub(env, "owner/repo", {
+      number: 7,
+      title: "x",
+      state: "open",
+      user: { login: "reader" },
+      author_association: "COLLABORATOR",
+      head: { sha: "sha" },
+    });
+
+    const client = await connect(env, { kind: "session", actor: "reader" } as AuthIdentity);
+    for (const name of READ_REPORT_TOOLS) {
+      const result = await client.callTool({ name, arguments: { owner: "owner", repo: "repo" } });
+      expect(result.isError, name).toBeFalsy();
+      const text = JSON.stringify(result);
+      expect(text, name).toContain("owner/repo");
+      expect(text, name).not.toMatch(/wallet|hotkey|raw trust|payout|reward estimate/i);
+    }
+    // Live lookup must not be required for these read tools after the fix (sibling write tools still use it).
+    expect(mockedPermission).not.toHaveBeenCalled();
+  });
+
+  it("rejects a session with no cached maintainer/owner scope on all three tools", async () => {
+    const env = createTestEnv();
+    await seedOwnedRepo(env);
+
+    const client = await connect(env, { kind: "session", actor: "rando" } as AuthIdentity);
+    for (const name of READ_REPORT_TOOLS) {
+      const result = await client.callTool({ name, arguments: { owner: "owner", repo: "repo" } });
+      expect(result.isError, name).toBe(true);
+      expect(JSON.stringify(result), name).toMatch(/Forbidden: session cannot access this repository/i);
+    }
+  });
+
+  it("allows the owning session when live collaborator lookup is unavailable", async () => {
+    const env = createTestEnv();
+    await seedOwnedRepo(env);
+
+    const client = await connect(env, { kind: "session", actor: "owner" } as AuthIdentity);
+    for (const name of READ_REPORT_TOOLS) {
+      const result = await client.callTool({ name, arguments: { owner: "owner", repo: "repo" } });
+      expect(result.isError, name).toBeFalsy();
+    }
+    expect(mockedPermission).not.toHaveBeenCalled();
+  });
+});