fix(queue): re-check loop-escalation via .loopover.yml override (#8018) - #8047
fix(queue): re-check loop-escalation via .loopover.yml override (#8018)#8047andriypolanski wants to merge 1 commit into
Conversation
…bored#8018) Add resolveLoopEscalationManifestOverride matching the other flag-gated cron jobs so a stale in-flight sweep honors config-as-code disablement. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-22 17:24:12 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
loop-escalation-sweepwas the only flag-gated cron inprocessJobthat checked the env var alone, so a.loopover.ymldisable could not stop an already-enqueued sweep.loopEscalation:(same shape asops:),resolveLoopEscalationManifestOverride, and wired it intoisLoopEscalationSweepEnabled,job-dispatch, and the hourly enqueue path.Closes #8018
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typecheck-t "loopEscalation|loop-escalation|#8018"across wire/queue/index/manifest/lint suites — 25 passed; config-templates yml sync checks passed.npm run test:workersnpm run build:mcpnpm run build:minernpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
test:cinot re-run here.loop-escalation-wire.tsremainsv8 ignore file(pre-existing); dispatch/cron coverage is via queue-5 + index tests.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — cron flag / config-as-code wiring; no UI.
Notes
resolveOpsManifestOverride/isOpsEnabled/ops-alertsdispatch case..loopover.ymlkey:loopEscalation.enabled(documented in.loopover.yml.example+loopover.full.yml).