fix(extension): remove dead matchPullRequestTarget from content script - #8045
Closed
lourincedaging0-commits wants to merge 1 commit into
Closed
Conversation
matchPullRequestTarget duplicated matchGitHubPageTarget minus the kind field and was left stranded by JSONbored#7462/JSONbored#7487 — nothing in production consumed it, only the __loopoverContentInternals test hook re-exported it. Remove the function and its export entry, and drop the now-dead assertions/type from the content-script test. Closes JSONbored#8023
Contributor
Author
|
Closing: this change is entirely within apps/loopover-extension (coverage-excluded), so the changed-file test run produces an empty coverage/lcov.info and the 'Verify coverage report exists' gate fails. The dead-code removal is still valid but needs a maintainer merge that bypasses that guard rather than the fork CI path. |
loopover-orb
Bot
added
the
gittensor:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchPullRequestTargetinapps/loopover-extension/content.jsduplicatedmatchGitHubPageTarget(minus thekindfield) and was left stranded when #7462/#7487 narrowed content-script matching topull/*and simplified theif (target)guard. Nothing in production consumed it — only the__loopoverContentInternalstest-hook re-exported it.Changes
matchPullRequestTargetand its entry in the__loopoverContentInternalsexport.matchPullRequestTargetassertions and type declaration fromtest/unit/extension-content.test.ts(thematchGitHubPageTargetcoverage in the same test is retained).node --check content.jspasses and the content-script test suite is green (5 tests).Closes #8023