fix(engine): delegate opportunityFreshnessFactor to its pure mirror with an injected clock

[RealDiligent]

Summary

• Closes opportunityFreshnessFactor still hand-duplicates its arithmetic and reads live Date.now(), unlike opportunityCompetitionFactor which #7529 converted to delegate to the pure mirror #8011
• opportunityFreshnessFactor (packages/loopover-engine/src/reward-risk.ts) hand-reimplemented pickIssueTimestamp/issueAgeDays/isParseableIssueTimestamp instead of delegating to computeOpportunityFreshness (./opportunity-freshness.js), which already carries the identical round4/clamp/exp(-age/20) formula — the exact duplicated-arithmetic setup whose drift fix(engine): opportunityCompetitionFactor doesn't fail closed on non-finite inputs like its own engine-mirror sibling does #7529 had to fix for its sibling opportunityCompetitionFactor. Worse, the duplicated issueAgeDays read a bare Date.now(), so buildRepoRewardRisk's freshness output was not deterministic the way the rest of the module claims.
• Fix (the issue's required pattern, mirroring opportunityCompetitionFactor's post-fix(engine): opportunityCompetitionFactor doesn't fail closed on non-finite inputs like its own engine-mirror sibling does #7529 shape in the same file): delegate to the pure mirror and thread an injectable nowMs clock through buildRepoRewardRisk / buildContributorRewardRiskStrategy, defaulting to Date.now() only at the buildRepoRewardRisk call boundary, never inside the pure calculators. Output is arithmetically identical for finite inputs (same timestamp pick order, same floor-to-days, same round4(clamp(exp(-age/20), 0.05, 1))).
• The now-redundant duplicated helpers are removed (net −37 lines); their surviving copies in opportunity-freshness.ts stay covered by its own opportunityFreshnessInternals tests. FreshnessIssue's optional timestamps gain the codebase-standard | undefined widening so IssueRecord[] is directly assignable under exactOptionalPropertyTypes.

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Ran the targeted suites for every test file exercising this module instead of the full sharded run: vitest run over reward-risk-freshness, reward-risk-engine-branch-coverage, opportunity-branch-internals, opportunity-competition, reward-risk-competition-fail-closed, reward-risk-reports, signals-coverage, signals-v2, decision-pack, maintainer-noise — 204 tests green — plus vitest run --coverage over the reward-risk suites: every changed line and branch (both sides of the args.nowMs ?? Date.now() boundary default) is covered. Also ran npm run build --workspace @loopover/engine (clean). actionlint/workers/mcp/ui checks are untouched surfaces (no workflow, worker, MCP, or UI files changed); CI runs them all.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — engine-only change (no UI, docs, or extension surface touched).

Notes

• The existing parity suite now injects the same clock on both sides (buildRepoRewardRisk({ ..., nowMs }) vs computeOpportunityFreshness(issues, nowMs)) — exact equality instead of wall-clock-proximity equality — and a new determinism test pins same-inputs + same-clock to the same factor and to the concrete round4(exp(-2/20)) = 0.9048 value, an assertion that was impossible while the hand-duplicated issueAgeDays read the live clock.
• The pickIssueTimestamp/issueAgeDays entries left rewardRiskFreshnessInternals with the deleted duplicates; the surviving single implementations remain covered through opportunityFreshnessInternals (test/unit/opportunity-branch-internals.test.ts). Tests that exercised the removed duplicates were replaced by the determinism test above; bestFitLabels coverage is untouched.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-22 17:24:09 UTC}

3 files · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
The AI review returned non-blocking notes for this change but did not include a separate narrative summary. Review the nits below before deciding this PR.

Nits — 1 non-blocking

• The FreshnessIssue type widening to `| undefined` (opportunity-freshness.ts) is a good exactOptionalPropertyTypes fix; worth a one-line mention in the PR description of which callers required it.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8011
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 371 registered-repo PR(s), 151 merged, 34 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 371 PR(s), 34 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, Ruby, JavaScript, Svelte, TypeScript, Markdown, MDX
• Official Gittensor activity: 371 PR(s), 34 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@37369b9). Learn more about missing BASE report.
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8039   +/-   ##
=======================================
  Coverage        ?   93.03%           
=======================================
  Files           ?      647           
  Lines           ?    54094           
  Branches        ?    19283           
=======================================
  Hits            ?    50325           
  Misses          ?     2850           
  Partials        ?      919           

Flag	Coverage Δ
shard-1	56.76% <100.00%> (?)
shard-2	52.67% <100.00%> (?)
shard-3	51.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...kages/loopover-engine/src/opportunity-freshness.ts	100.00% <ø> (ø)
packages/loopover-engine/src/reward-risk.ts	100.00% <100.00%> (ø)