fix(control-plane): product-scope TenantRegistry keys (#8024)

[andriypolanski]

Summary

• TenantRegistry (fake + KV) keyed records by tenant name alone, so provisioning ORB acme then AMS acme hit a false 409, and deprovisioning one overwrote the other's inventory row.
• Storage and HTTP lookups now use ${product}:${name} (same as container-driver.ts's instanceNameFor). DELETE /v1/tenants/:name requires ?product=; GET /v1/tenants still lists every product.

Closes #8024

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Control-plane-only change: npm --prefix control-plane test (98 pass) and npm run control-plane:coverage — tenant-registry.ts and http-app.ts at 100% lines/branches. Root vitest/UI/MCP gates do not cover control-plane/src/**.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — control-plane registry/HTTP keying only; no UI.

Notes

• Analogue: control-plane/src/container-driver.ts instanceNameFor / test/container-driver.test.ts product-scoped key test.
• DELETE now requires ?product= so the composite key can be resolved. Miner destroyTenant still omits product (follow-up if needed).

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-22 17:23:59 UTC}

4 files · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a well-targeted fix for #8024: TenantRegistry now keys records by `${product}:${name}` (both the in-memory fake and the KV-backed implementation), so ORB and AMS tenants sharing a name no longer collide on create or overwrite each other on teardown. The HTTP layer is updated in lockstep — `get()` now takes `product`, and `DELETE /v1/tenants/:name` requires a `?product=` query param, with a 400 test for the missing-param case and an end-to-end test proving ORB/AMS independence through create and delete. The change is narrow, the composite-key convention matches `container-driver.ts`'s existing `instanceNameFor`, and the diff includes matching test coverage for every new branch I can see.

Nits — 3 non-blocking

• The 'magic numbers' flagged in the brief (400, control-plane's TenantRegistry keys tenant records by name only, not (product, name) — cross-product tenant-name collision in the live HTTP API #8024) are not real issues — 400 is a standard HTTP status already used elsewhere in this file, and control-plane's TenantRegistry keys tenant records by name only, not (product, name) — cross-product tenant-name collision in the live HTTP API #8024 is an issue reference in a comment, not a numeric literal needing a constant.
• tenant-registry.ts's `instanceKeyFor` and `keyFor` both build composite keys with no delimiter-collision guard (e.g. product `orb:x` name `y` vs product `orb` name `x:y` could theoretically collide) — not exploitable in practice since `Product` is a closed enum, but worth a one-line note if that assumption ever changes.
• Consider adding a Product type-level comment near `instanceKeyFor` noting the delimiter-safety assumption relies on `Product` being a fixed, colon-free enum, so a future free-text product field doesn't silently reintroduce the collision (control-plane/src/tenant-registry.ts:27).

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8024
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 208 registered-repo PR(s), 130 merged, 22 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	andriypolanski; Gittensor profile; 208 PR(s), 22 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Linked issue satisfaction

Addressed
The diff keys TenantRegistry storage by `${product}:${name}` in both fake and KV implementations, updates http-app.ts's create conflict-check and delete lookup to use the same composite key (adding a required `product` query param to DELETE), and adds the requested cross-product regression test showing independent provisioning/deprovisioning of same-named ORB/AMS tenants. GET /v1/tenants still lis

Review context

• Author: andriypolanski
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, TypeScript, JavaScript, Rust, Cuda, Kotlin, MDX, Scala
• Official Gittensor activity: 208 PR(s), 22 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review