Skip to content

fix(services): redact 'private key' from the agent-action public-safe card (#8020) #8027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 22, 2026
Merged

fix(services): redact 'private key' from the agent-action public-safe card (#8020) #8027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/agent-action-explanation-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ type AgentActionExplanationInput = Pick<

const BLOCKER_CATEGORY_ORDER: AgentActionBlockerCategory[] = ["branch", "account", "queue", "scoreability", "risk", "maintainer", "unknown"];
const PUBLIC_FORBIDDEN_PATTERN =
/\b(wallets?|hotkeys?|coldkeys?|seed phrases?|mnemonics?|raw[-_\s]?trust scores?|trust scores?|private reviewability|reviewability internals?|private scoreability|scoreability|projected scores?|score(?:d|s|ability)?|public score estimates?|estimated scores?|score estimates?|score previews?|reward estimates?|payouts?|farming|reward optimization|private rankings?)\b/gi;
/\b(wallets?|hotkeys?|coldkeys?|seed phrases?|mnemonics?|private keys?|raw[-_\s]?trust scores?|trust scores?|private reviewability|reviewability internals?|private scoreability|scoreability|projected scores?|score(?:d|s|ability)?|public score estimates?|estimated scores?|score estimates?|score previews?|reward estimates?|payouts?|farming|reward optimization|private rankings?)\b/gi;
const PUBLIC_SCORE_DELTA_PATTERN = /\b(?:projected\s+)?score\w*(?:\s+\w+){0,4}\s+[-+]?\d+(?:\.\d+)?\s*->\s*[-+]?\d+(?:\.\d+)?\b/gi;
// Token alternatives stay local; the local-path alternatives compose from the canonical PUBLIC_LOCAL_PATH_INLINE
// in redaction.ts (adds the previously-missed /root/ and /var/, plus the forward-slash Windows form C:/Users/).
Expand Down
18 changes: 18 additions & 0 deletions test/unit/agent-orchestrator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,24 @@ describe("agent orchestrator", () => {
expect(card.publicSafe.summary).not.toMatch(/\/root\/work|\/var\/log|C:\/Users\/alice/);
});

it("redacts 'private key' from the public-safe card, matching its sibling redaction lists (#8020)", () => {
// `private keys?` was present in 5 sibling public-redaction vocabularies (miner-dashboard-recommendations.ts:45,
// control-panel-roles.ts:297, decision-pack.ts:1438, weekly-value-report.ts:417, extension-contributor-context.ts:31)
// but missing here, so an App-credential reference leaked through publicSafe.whyNow unredacted.
const card = buildAgentActionExplanationCard({
actionType: "choose_next_work",
status: "blocked",
why: ["Blocked by a private key rotation on the App credential."],
blockedBy: ["private key rotation pending"],
publicSafeSummary: "Resolve the App private key rotation before rerunning.",
safetyClass: "private",
});

expect(card.publicSafe.summary).not.toMatch(/private key/i);
expect(card.publicSafe.summary).toMatch(/private context/);
expect(card.publicSafe.whyNow).not.toMatch(/private key/i);
});

it("does not split a surrogate pair when truncating a card field at the 300-character cap", () => {
// A string is well-formed UTF-16 iff it has no lone surrogate (a high surrogate not followed by a
// low one, or a low surrogate not preceded by a high one). Equivalent to String#isWellFormed without
Expand Down