fix(review): downgrade REES 413 response to warn, not error#7988
Merged
Conversation
A large diff/context exceeding REES's own request-size cap is an expected, already-handled degradation (review proceeds with no enrichment brief, same as any other http_error outcome) -- not a broken REES instance. Logging it at error paged/alerted on routine oversized payloads instead of genuine REES failures.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7988 +/- ##
==========================================
- Coverage 91.91% 89.26% -2.66%
==========================================
Files 739 95 -644
Lines 75845 22050 -53795
Branches 23016 3834 -19182
==========================================
- Hits 69712 19682 -50030
+ Misses 5041 2187 -2854
+ Partials 1092 181 -911
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http_erroroutcome) -- not a broken REES instance.errorwas paging/alerting on routine oversized payloads instead of genuine REES failures, and was flagged by a new Sentry issue surfacing as noise.warn; every other non-2xx status still logs aterroras before.Test plan
warn(noterror) with the correct structured payload, and that metrics are unaffectednpm run test:cifull local gate greennpm run test:coverage(unsharded) confirms 100% patch coverage on the changed lines/branches