fix(ui): restore gittensory_ legacy localStorage keys destroyed by rebrand (#7782)

[kai392]

Summary

The Phase-5 blanket gittensory→loopover rename also rewrote two intentional pre-rebrand legacyKey string literals, so key === legacyKey and useLocalStorage's migration path became a no-op (#7782). A maintainer who dismissed the onboarding preview or opted into notifications before the rebrand silently lost that preference.

Restore the distinct gittensory_... legacy literals (matching the surviving pattern in try-it.tsx), add a regression test per component that seeds the legacy key and asserts migration + UI state, and update scripts/branding-drift-baseline.json so the intentional historical gittensory_ keys are recorded (these are rebrand migration fallbacks, not new branding drift).

Visual note: string-literal / storage-migration only — at-rest UI is unchanged; before/after shots are pixel-identical by design.

Closes #7782

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint (eslint on the four touched UI files)
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries
• npm run branding-drift:check (baseline updated for intentional gittensory_ legacy keys)

If any required check was skipped, explain why:

• Change is confined to apps/loopover-ui + the branding-drift baseline. Ran package-local prettier + eslint + vitest on the two component test files (11/11 pass) and npm run branding-drift:check locally. Root workers/MCP/OpenAPI are unrelated.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Dark theme only (loopover-ui has no light theme). Annotated cards call out the restored gittensory_ → loopover_ key pairs. Before and after are pixel-identical — the fix is storage-key migration only.

Viewport × Theme	Before	After
Desktop · Dark
Tablet · Dark
Mobile · Dark

Notes

• Resubmit of fix(ui): restore gittensory_ legacy localStorage keys destroyed by rebrand (#7782) #7908, which was auto-closed for red CI: branding-drift rejected the intentional gittensory_ legacy-key restores. This tip updates scripts/branding-drift-baseline.json so the check passes.
• No follow-up pushes on this tip (LoopOver one-shot rule).

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
6460	1	6459	2

View the full list of 1 ❄️ flaky test(s)

test/unit/mcp-cli-activation-preview.test.ts > test/unit/mcp-cli-activation-preview.test.ts

Flake rate in main: 60.00% (Passed 2 times, Failed 3 times)

Stack Traces | 10s run time

Error: Hook timed out in 10000ms.
If this is a long-running hook, pass a timeout value as the last argument or configure it globally with "hookTimeout".
 ❯ test/unit/mcp-cli-activation-preview.test.ts:31:1

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[loopover-orb]

Caution

🛑 LoopOver review result - fixes required

_{Review updated: 2026-07-21 17:27:10 UTC}

5 files · 1 AI reviewer · no blockers · CI failing · blocked

🛑 Suggested Action - Fix Blockers

Review summary
This restores two `gittensory_`-prefixed legacy localStorage keys (onboarding-preview dismiss flag, notification opt-in) that a prior blanket rebrand incorrectly rewrote to match their new-key counterparts, which had silently broken `useLocalStorage`'s migration fallback since `key === legacyKey`. The fix is correct and minimal — restoring the distinct legacy literals, updating the branding-drift baseline to record them as intentional, and adding a migration-path regression test per component that seeds the legacy key and asserts the new key gets populated and UI reflects the migrated state. Tests genuinely exercise the real migration path (via `useLocalStorage`) rather than fabricating an unreachable scenario.

Nits — 5 non-blocking

• The two FAILED CI checks (validate-tests (1)/(2), validate) show no detail, so their cause can't be verified from what's given here — worth confirming they're unrelated to this change.
• onboarding-preview-card.tsx:21 keeps a slightly redundant two-line comment (one pre-existing, one new) explaining the same constraint — could consolidate into one line.
• Consider adding a one-line comment in try-it.tsx (if not already present) cross-referencing these two restored keys, so future rebrand-style renames grep for `gittensory_` before blanket-replacing.
• Possible screenshot-table issue: identical images (row 1) — Advisory only — verify the screenshot-table images against the stated change before deciding.
• Possible screenshot-table issue: identical images (row 2) — Advisory only — verify the screenshot-table images against the stated change before deciding.

CI checks failing

• validate
• validate-tests (1)
• validate-tests (2)

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7782
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 47 registered-repo PR(s), 27 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	kai392; Gittensor profile; 47 PR(s), 0 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff restores distinct pre-rebrand gittensory_ literals for both LEGACY_DISMISS_KEY and the notification opt-in legacy key, matching the try-it.tsx pattern, and adds regression tests for each component confirming the legacy value is migrated forward and reflected in UI state.

Review context

• Author: kai392
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: JavaScript, Kotlin, Perl, TypeScript, Vue
• Official Gittensor activity: 47 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
/	desktop	before /	after /	—
/	mobile	before / (mobile)	after / (mobile)	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
/	before / (scroll)	after / (scroll)

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests (1), validate-tests (2))). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.