feat(mcp): register loopover_propose_action as a local stdio MCP tool - #7902
Closed
tryeverything24 wants to merge 1 commit into
Closed
feat(mcp): register loopover_propose_action as a local stdio MCP tool#7902tryeverything24 wants to merge 1 commit into
tryeverything24 wants to merge 1 commit into
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
tryeverything24
force-pushed
the
loopover-mcp-propose-action-stdio-tool
branch
from
July 21, 2026 16:54
998dd34 to
b50ec15
Compare
This was referenced Jul 21, 2026
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Closes JSONbored#7753 Mirrors the exact registerStdioTool pattern PR JSONbored#6382 used for the 5 maintain-surface siblings (loopover_list_pending_actions et al): the handler calls the same bare POST .../agent/pending-actions endpoint `maintain propose` already calls, through the same apiPost client, and its description comes from the same stdioToolDescription centralized lookup. JSONbored#6744 added the route + CLI mirror without a stdio registration, so it fell outside JSONbored#6152's batch despite being the same family. The route's response always carries a fully-populated `action` (id/actionClass/status set unconditionally, per src/api/routes.ts's POST handler) -- only `created` genuinely varies, so that's the only branch the handler formats defensively. New dedicated suite (mcp-cli-propose-action-tool.test.ts) covers registration, the proxy contract, both the "Staged"/"Already staged" branches, an API-failure path, and pre-flight schema rejection -- following mcp-cli-maintain- tools.test.ts's shape. Bumped the pinned stdio tool count 80 -> 81 in mcp-tool-rename-aliases.test.ts (rebased past JSONbored#7877's own 79 -> 80 bump).
tryeverything24
force-pushed
the
loopover-mcp-propose-action-stdio-tool
branch
from
July 21, 2026 16:59
b50ec15 to
c151b75
Compare
Contributor
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers
loopover_propose_actionas a local stdio MCP tool inpackages/loopover-mcp/bin/loopover-mcp.ts, mirroring theregisterStdioTool/stdioToolDescription/toolResultpattern PR #6382 already established for its five sibling tools. Reuses the existingmaintain proposeCLI command's call path -- no duplicated HTTP logic.Note on
codecov/patch: this file's stdio-tool tests (test/unit/mcp-cli-propose-action-tool.test.ts, 8 tests) spawn the CLI as a real subprocess vianode --experimental-strip-typesagainst the actual edited source (seetest/unit/support/mcp-cli-harness.ts), not a stale prebuilt bundle -- the tests genuinely exercise the new code, but v8/istanbul coverage cannot instrument a child process, socodecov/patchreporting 0% here is a known tooling limitation of this file, not a gap in test coverage (same shape as PR #7877, an identical stdio-tool-registration PR that was merged despite the same report).Closes #7753