fix(queue): fast-track a PR whose merge/close got denied by a live staleness recheck - #7886
Merged
Merged
Conversation
…aleness recheck A duplicate-cluster winner merging, a base conflict clearing, or GitHub finishing its async mergeable_state computation all carry no webhook to the affected PR, so a review-good PR left in this state waited out the ordinary sweep cadence instead of getting a prompt re-look. Extends the existing outage-repair priority set (surfaceRepairPriorityPullNumbers) to also fast-track these cases, reusing its existing per-head-SHA attempt cap so a genuinely stuck PR still falls back to ordinary cadence.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7886 +/- ##
==========================================
- Coverage 91.40% 90.23% -1.17%
==========================================
Files 730 90 -640
Lines 74763 26200 -48563
Branches 22815 5401 -17414
==========================================
- Hits 68335 23642 -44693
+ Misses 5385 2241 -3144
+ Partials 1043 317 -726
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surfaceRepairPriorityPullNumbers) to also fast-track: (1) a PR the bot already approved at its current head whosemergeable_stateis still ambiguous (neither clean nor dirty), and (2) a PR whose most recent close/merge attempt was denied by one of those three self-resolving live staleness rechecks (newrecentStaleRecheckDeniedPullNumbersquery). Both inherit the existing per-head-SHA attempt cap, so a genuinely stuck PR still falls back to ordinary cadence rather than being re-selected forever.Test plan
npm run typechecktest/unit/surface-repair-priority.test.ts(9 cases) + additions totest/unit/db-parsers.test.ts(8 cases, incl. a source-text parity guard against wording drift in agent-action-executor.ts)vitest --coverage)npm run test:coverage: only pre-existing, environment-dependent failures (missingpackages/loopover-mcp/loopover-minerbuild output in a freshnpm ci, missing Claude API credentials) — none touch the changed files; confirmed by rebuilding those sub-packages and seeing the affected tests pass