fix(review): paginate getLatestDeploymentStatus deployments and statuses (#7805) - #7822
fix(review): paginate getLatestDeploymentStatus deployments and statuses (#7805)#7822kai392 wants to merge 2 commits into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…ses (JSONbored#7805) Reuse findAcrossPages for both GitHub list reads so preview URL discovery does not silently miss deployments or statuses beyond page 1. Closes JSONbored#7805 Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7822 +/- ##
==========================================
- Coverage 88.65% 88.53% -0.13%
==========================================
Files 730 89 -641
Lines 76959 21360 -55599
Branches 22787 3727 -19060
==========================================
- Hits 68229 18911 -49318
+ Misses 7684 2247 -5437
+ Partials 1046 202 -844
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-21 13:57:56 UTC
Review summary Nits — 5 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
…e only Avoid a redundant page-1 refetch after pagination and satisfy exactOptionalPropertyTypes for latestState. Co-authored-by: Cursor <cursoragent@cursor.com>
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, codecov/patch, validate-tests (3))). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
getLatestDeploymentStatusdeployments-list and per-deployment-statuses reads viafindAcrossPages, matching the sibling functions already fixed in fix(review): paginate preview-url.ts's PR-comment and check-run GitHub reads #7469.findAcrossPagesto accept async probes so deployment pages can nest status pagination.Closes #7805
Test plan
test/unit/preview-url.test.tsfor both pagination gapssrc/review/**