Skip to content

fix(ui-kit): edge-trigger StateBoundary failure notifications#7505

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/state-boundary-edge-notify-7436-v2
Jul 20, 2026
Merged

fix(ui-kit): edge-trigger StateBoundary failure notifications#7505
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/state-boundary-edge-notify-7436-v2

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • Make StateBoundary's onFailureNotify effect edge-triggered (false→true of isError && errorLabel) via a wasFailureNotifyActive ref, matching the documented "flips into" intent.
  • Narrow with if (isError && errorLabel && !wasFailureNotifyActive.current) so errorLabel is typed without a non-null assertion.
  • Add a regression test that re-renders with fresh callback identities while still in error (exactly one notify), then leaves and re-enters error (second notify).

Closes #7436

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Local gates: npm run build --workspace @loopover/ui-kit and npm run test --workspace @loopover/ui -- src/components/site/state-views.test.tsx (15 pass). Remaining checks deferred to CI.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Behavior-only fix (notification edge-trigger). No at-rest visual delta — before and after are the same production dark-mode captures at each required viewport. loopover-ui is dark-mode-only.

Viewport · Theme Before After
Desktop · Dark Desktop · Dark before Desktop · Dark after
Tablet · Dark Tablet · Dark before Tablet · Dark after
Mobile · Dark Mobile · Dark before Mobile · Dark after

Notes

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 20, 2026 13:50
@github-actions
github-actions Bot had a problem deploying to preview/pr-7505 July 20, 2026 13:52 Failure
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 20, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb

loopover-orb Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-20 13:55:54 UTC

2 files · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This correctly converts StateBoundary's onFailureNotify effect from level-triggered to edge-triggered using a `wasFailureNotifyActive` ref: it notifies on the false→true transition of `(isError && errorLabel)` and suppresses re-notification while already in error and identity-unstable props (e.g. a fresh `onRetry` arrow) cause the effect to re-run. The added test exercises the exact defect scenario (identity churn while errorred, then a leave/re-enter cycle) and asserts the notify count at each step, which matches the fix's stated intent. The change is narrow, self-contained, and includes both edges of the added condition.

Nits — 4 non-blocking
  • packages/loopover-ui-kit/src/components/state-views.tsx:268-271 — the inline comment is quite long for a one-line behavioral note; could be trimmed to the edge-trigger rationale without the full app-wrapper narrative.
  • No test covers the case where `isError` stays true but `errorLabel` changes value mid-error (ref stays true, so no re-notify) — worth a one-line comment or test asserting that's intentional, since it's a real but unexercised branch of the new guard.
  • Consider renaming `wasFailureNotifyActive` to something shorter like `wasActiveRef` for readability, though the current name is accurate.
  • If a label change mid-error should re-surface the toast, track the label itself in the ref instead of just a boolean; if not, a short comment confirming that's out of scope would help future readers.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7436
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 370 registered-repo PR(s), 171 merged, 34 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 370 PR(s), 34 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The StateBoundary effect now tracks previous error state via a wasFailureNotifyActive ref and only invokes onFailureNotify on the false→true transition, matching the mcp-version-badge precedent and preserving re-entry firing. A regression test in state-views.test.tsx exercises re-renders with fresh callback identities while errored (exactly one call) and an error→ready→error cycle (fires again), s

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, Ruby, Svelte, TypeScript, Markdown, MDX
  • Official Gittensor activity: 370 PR(s), 34 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview
Route Before (production) After (this PR's preview)
/ before / (scroll)
before / (scroll)

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit fa67da4 into JSONbored:main Jul 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ui-kit): StateBoundary re-notifies on every re-render while isError is true, not once per transition

1 participant