chore(scripts): remove orphaned github-type-label.d.mts - #7475
Conversation
The github-type-label.mjs implementation (plus its workflow and test) was deleted in JSONbored#1088 (commit 01c315b) when type-labeling was consolidated into the review's own resolvePrTypeLabel/ensurePullRequestLabel path, but its hand-written .d.mts type declaration was left behind. It is the only .d.mts under scripts/ without a matching .mjs implementation, and a repo-wide search for 'github-type-label' finds no remaining references. Remove the orphan. Closes JSONbored#7434
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7475 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 717 717
Lines 73016 73016
Branches 21631 21631
=======================================
Hits 66713 66713
Misses 5265 5265
Partials 1038 1038
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-20 11:50:08 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #7434
What
scripts/github-type-label.d.mtsis an orphaned type-declaration file. Its.mjsimplementation (plus the workflow and test) was deleted in #1088 (01c315bcf) when issue/PR type-labeling was consolidated into the review's ownresolvePrTypeLabel/ensurePullRequestLabelpath — but the.d.mtswas left behind.It is the only
.d.mtsunderscripts/without a matching.mjssibling, and a repo-wide search forgithub-type-label(.github/**,scripts/**,src/**,test/**,package.json) finds no remaining references. Removing the orphan.Verification
github-type-labelsearch per the issue's requirement: only the orphaned file itself; nothing imports or type-checks against it. After deletion, the search returns nothing.scripts/(not in codecov'scoverage.include); no behavior change.