Skip to content

chore(scripts): remove orphaned github-type-label.d.mts - #7475

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:chore/remove-orphaned-github-type-label-dts-7434
Jul 20, 2026
Merged

chore(scripts): remove orphaned github-type-label.d.mts#7475
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:chore/remove-orphaned-github-type-label-dts-7434

Conversation

@lourincedaging0-commits

Copy link
Copy Markdown
Contributor

Closes #7434

What

scripts/github-type-label.d.mts is an orphaned type-declaration file. Its .mjs implementation (plus the workflow and test) was deleted in #1088 (01c315bcf) when issue/PR type-labeling was consolidated into the review's own resolvePrTypeLabel/ensurePullRequestLabel path — but the .d.mts was left behind.

It is the only .d.mts under scripts/ without a matching .mjs sibling, and a repo-wide search for github-type-label (.github/**, scripts/**, src/**, test/**, package.json) finds no remaining references. Removing the orphan.

Verification

  • Re-ran the repo-wide github-type-label search per the issue's requirement: only the orphaned file itself; nothing imports or type-checks against it. After deletion, the search returns nothing.
  • Single-file deletion in scripts/ (not in codecov's coverage.include); no behavior change.

The github-type-label.mjs implementation (plus its workflow and test) was deleted in
JSONbored#1088 (commit 01c315b) when type-labeling was consolidated into the review's own
resolvePrTypeLabel/ensurePullRequestLabel path, but its hand-written .d.mts type
declaration was left behind. It is the only .d.mts under scripts/ without a matching
.mjs implementation, and a repo-wide search for 'github-type-label' finds no remaining
references. Remove the orphan.

Closes JSONbored#7434
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.36%. Comparing base (582fc3a) to head (bdd248a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7475   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         717      717           
  Lines       73016    73016           
  Branches    21631    21631           
=======================================
  Hits        66713    66713           
  Misses       5265     5265           
  Partials     1038     1038           
Flag Coverage Δ
shard-1 34.16% <ø> (ø)
shard-2 39.31% <ø> (ø)
shard-3 32.62% <ø> (+0.01%) ⬆️
shard-4 39.53% <ø> (ø)
shard-5 36.58% <ø> (ø)
shard-6 34.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 20, 2026
@loopover-orb

loopover-orb Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-20 11:50:08 UTC

1 file · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR deletes an orphaned type-declaration file (scripts/github-type-label.d.mts) whose corresponding .mjs implementation, workflow, and tests were already removed in #1088, leaving it with no references anywhere in the repo. It closes issue #7434, is a single-file, pure-deletion change with no behavior impact, and the description documents a repo-wide search confirming no remaining references. This is exactly the kind of narrow, well-scoped cleanup the maintainer guidelines call for.

Nits — 3 non-blocking
  • No test-path changes are expected or needed here since this is a dead-code deletion with no runtime behavior — flagged only for completeness, not as an actionable gap.
  • Consider a quick `grep -r github-type-label` in CI or a lint rule to catch orphaned .d.mts files earlier next time a .mjs implementation is deleted.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7434
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 97 registered-repo PR(s), 46 merged, 5 issue(s).
Contributor context ✅ Confirmed Gittensor contributor lourincedaging0-commits; Gittensor profile; 97 PR(s), 5 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Addressed
The PR deletes scripts/github-type-label.d.mts exactly as requested and documents a re-verification that no other references to github-type-label remain.

Review context
  • Author: lourincedaging0-commits
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: HTML
  • Official Gittensor activity: 97 PR(s), 5 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit dca5d66 into JSONbored:main Jul 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(scripts): remove orphaned scripts/github-type-label.d.mts (implementation deleted in #1088, type file left behind)

1 participant