fix(signals): remove unreachable OpenPrWorkClassification stale

[RealDiligent]

Summary

• Remove the dead "stale" value from OpenPrWorkClassification and its consumers in the open-PR monitor (cleanupFirst, nextStepsForClassification, priorityRank).
• Drop matching references in the agent orchestrator urgent set, OpenAPI schema, and regenerated openapi.json, and update fixtures that hand-cast the removed literal.

Why

mapPendingClassToWorkClassification never produced "stale" — upstream stale_likely_close already maps to should_close_or_withdraw. Keeping the unreachable variant was misleading dead code.

Closes #7448

Test plan

• npm run typecheck
• npx vitest run test/unit/contributor-open-pr-monitor.test.ts test/unit/agent-orchestrator.test.ts
• npm run ui:openapi / ui:openapi:check
• git diff --check
• CI green (especially codecov/patch ≥99%)

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-20 11:20:13 UTC}

6 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR removes the unreachable "stale" literal from OpenPrWorkClassification and its consumers (cleanupFirst, nextStepsForClassification, priorityRank), plus matching references in the agent orchestrator, OpenAPI schema/JSON, and updates fixtures that referenced the removed literal. The change is well-traced: mapPendingClassToWorkClassification never produces "stale" since stale_likely_close already maps to should_close_or_withdraw, so this is a legitimate dead-code removal rather than a functional change. Tests were updated consistently (agent-orchestrator.test.ts, contributor-open-pr-monitor.test.ts) to swap "stale" fixtures for "should_close_or_withdraw", and the OpenAPI schema/JSON stay in sync with the TypeScript union.

Nits — 4 non-blocking

• The size-smell flags on openapi.json, schemas.ts, and agent-orchestrator.ts are pre-existing file lengths, not something introduced by this small removal — no action needed here.
• test/unit/contributor-open-pr-monitor.test.ts:349-350 — the new comment is helpful but slightly redundant with the PR description; consider trimming to one line referencing fix(signals): remove the unreachable "stale" OpenPrWorkClassification value #7448 only.
• Confirm there are no other call sites (e.g. dashboards, docs, or other fixtures outside the diff) that still reference the literal "stale" for this classification, since the diff only shows six files.
• Since this closes fix(signals): remove the unreachable "stale" OpenPrWorkClassification value #7448, double-check the issue's acceptance criteria are fully covered by removing just these four call sites (cleanupFirst, nextStepsForClassification, priorityRank, agent-orchestrator urgent set).

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7448
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 373 registered-repo PR(s), 173 merged, 34 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 373 PR(s), 34 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: minor

Linked issue satisfaction

Addressed
The diff removes "stale" from the OpenPrWorkClassification union and all three consumers (cleanupFirst array, nextStepsForClassification switch, priorityRank array) exactly as required, and also updates dependent schemas/orchestrator code and test fixtures that referenced the literal. It matches the issue's scoped, mechanical dead-code removal without altering other classifications' behavior.

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, Ruby, Svelte, TypeScript, Markdown, MDX
• Official Gittensor activity: 373 PR(s), 34 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
/	desktop	before /	after /	—
/	mobile	before / (mobile)	after / (mobile)	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
/	before / (scroll)	—

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

This pull request changes UI/visual code but its screenshot evidence is incomplete. Every required viewport × theme combination needs its own before/after image pair in a labeled table row (e.g. "Desktop · Light | before | after"). Still missing: Desktop · Dark, Tablet · Dark, Mobile · Dark.

Please resubmit with the remaining rows filled in.

See https://github.com/JSONbored/loopover/blob/main/.claude/skills/contributing-to-loopover/SKILL.md for the exact format and examples. This is an automated maintenance action.