chore(mcp): convert lib/local-branch to TypeScript - #7418
chore(mcp): convert lib/local-branch to TypeScript#7418lourincedaging0-commits wants to merge 1 commit into
Conversation
Phase 2 of the packages/loopover-mcp TypeScript migration (JSONbored#7291), building on the tsc build pipeline from Phase 1 (JSONbored#7409). Port lib/local-branch.js to lib/local-branch.ts; it compiles in place to lib/local-branch.js (inline source map, no .d.ts), the same file set the package already ships. Runtime behavior and the public export surface are unchanged: every exported function keeps its name and semantics, and bin/loopover-mcp.js consumes the compiled .js exactly as before. Types are added at the git-diff/JSON/scorer boundaries as open records, matching the already-converted lib/ files. Closes JSONbored#7329
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7418 +/- ##
===========================================
- Coverage 91.27% 80.83% -10.45%
===========================================
Files 716 84 -632
Lines 72972 22642 -50330
Branches 21527 3648 -17879
===========================================
- Hits 66605 18302 -48303
+ Misses 5327 4162 -1165
+ Partials 1040 178 -862
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Caution 🛑 LoopOver review result - reject/close recommendedReview updated: 2026-07-20 08:48:47 UTC
Review summary Blockers
Nits — 6 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentCI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests-merge, validate-code); AI reviewers agree on a likely critical defect: CI is failing on validate, validate-tests-merge, and validate-code for this commit — these need to be green before merge, and nothing in the diff or description explains the failures.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Phase 2 of the
packages/loopover-mcpTypeScript migration (#7291), on the tsc pipeline from Phase 1 (#7409).What
Port
lib/local-branch.js→lib/local-branch.ts. The tsconfigincludeglob (lib/**/*.ts) picks it up; it compiles in place tolib/local-branch.js(inline source map, no.d.ts) — the same layout the package already ships, so no import path changes.Behavior
Runtime behavior and the public export surface are unchanged — every exported function keeps its name and semantics,
bin/loopover-mcp.jsandtest/unit/local-scorer-adapter.test.tsconsume the compiled.jsexactly as before. Types are added at the git-diff / scorer-JSON boundaries as open records, matching the already-convertedlib/files, so the strict build stays clean without narrowing the dynamic shapes.Closes #7329